Skip to content

Conversation

@sota1235
Copy link
Contributor

No description provided.

@sota1235 sota1235 self-assigned this Mar 10, 2017
@asmsuechan
Copy link
Contributor

asmsuechan commented Mar 10, 2017

Hi @sota1235, it does not work at least in my environment. the way how to test is below:

  1. Add line let a = 1
  2. Run npm run lint

However, nothing happens.

@sota1235
Copy link
Contributor Author

@asmsuechan I fixed npm script bug. Then more then 500 errors occurs 😭
So firstly, add prefer-const rule as warning and fix little by little.
Plz review again 🙇

Copy link
Contributor

@kohei-takata kohei-takata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Copy link
Contributor

@asmsuechan asmsuechan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@sota1235
Copy link
Contributor Author

Thanks a lot for reviewing.

@sota1235 sota1235 merged commit 359f673 into master Mar 21, 2017
@sota1235 sota1235 deleted the feature-add-esilnt-rule branch March 21, 2017 06:16
@sota1235 sota1235 mentioned this pull request Apr 22, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants