Skip to content

Conversation

@tobysoby
Copy link
Contributor

@tobysoby tobysoby commented Jul 7, 2019

Description

When I search for something and delete the search term from the search field, the search term doesn't stay highlighted in the editor panel.

Issue fixed

Deleted search term stays highlighted · Issue #3111 · BoostIO/Boostnote · GitHub

Type of changes

  • 🔘 Bug fix (Change that fixed an issue)
  • ⚪ Breaking change (Change that can cause existing functionality to change)
  • ⚪ Improvement (Change that improves the code. Maybe performance or development improvement)
  • ⚪ Feature (Change that adds new functionality)
  • ⚪ Documentation change (Change that modifies documentation. Maybe typo fixes)

Checklist:

  • 🔘 My code follows the project code style
  • ⚪ I have written test for my code and it has been tested
  • 🔘 All existing tests have been passed
  • ⚪ I have attached a screenshot/video to visualize my change if possible

@ZeroX-DG ZeroX-DG added awaiting review ❇️ Pull request is awaiting a review. approved 👍 Pull request has been approved by sufficient reviewers. and removed awaiting review ❇️ Pull request is awaiting a review. labels Jul 14, 2019
Copy link
Member

@ZeroX-DG ZeroX-DG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

@Rokt33r Rokt33r removed the approved 👍 Pull request has been approved by sufficient reviewers. label Jul 22, 2019
@Rokt33r Rokt33r added this to the v0.12.0 milestone Jul 22, 2019
@Rokt33r Rokt33r merged commit e940253 into BoostIO:master Jul 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants