Skip to content

Conversation

@dtom90
Copy link
Contributor

@dtom90 dtom90 commented Jun 12, 2019

Description

Changes the mac hotkey to insert today's date & time from Shift-Cmd-/ to Alt-Cmd-/
Screen Shot 2019-06-12 at 18 12 08
As described in #3074, Shift-Cmd-/ opens the Help menu of the application.

Issue fixed

#3074

Type of changes

  • 🔘 Bug fix (Change that fixed an issue)
  • ⚪ Breaking change (Change that can cause existing functionality to change)
  • ⚪ Improvement (Change that improves the code. Maybe performance or development improvement)
  • ⚪ Feature (Change that adds new functionality)
  • ⚪ Documentation change (Change that modifies documentation. Maybe typo fixes)

Checklist:

  • 🔘 My code follows the project code style
  • 🔘 I have written test for my code and it has been tested
  • 🔘 All existing tests have been passed
  • 🔘 I have attached a screenshot/video to visualize my change if possible

@ZeroX-DG ZeroX-DG added the awaiting review ❇️ Pull request is awaiting a review. label Jun 13, 2019
Copy link
Member

@ZeroX-DG ZeroX-DG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

@ZeroX-DG ZeroX-DG added approved 👍 Pull request has been approved by sufficient reviewers. and removed awaiting review ❇️ Pull request is awaiting a review. labels Jun 13, 2019
@nathan-castlehow
Copy link
Contributor

Is it worth adding an option for this to the hot key config also?

@dtom90
Copy link
Contributor Author

dtom90 commented Jun 15, 2019

@nathan-castlehow I'll implement this since I already started working on it

@dtom90
Copy link
Contributor Author

dtom90 commented Jun 16, 2019

I moved these hotkey settings into ConfigManager.js and added fields to the settings hotkey tab, but I could not get the hotkeys to update if they were modified, so I simply made the fields disabled in settings.

@Rokt33r Rokt33r merged commit a508523 into BoostIO:master Jul 8, 2019
@Rokt33r Rokt33r added this to the v0.12.0 milestone Jul 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved 👍 Pull request has been approved by sufficient reviewers.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants