Skip to content

Fix export to PDF exporting corrupted images #3068

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Rokt33r merged 1 commit into from
Jul 8, 2019
Merged

Fix export to PDF exporting corrupted images #3068

Rokt33r merged 1 commit into from
Jul 8, 2019

Conversation

@KazumiHARADA
Copy link
Contributor

@KazumiHARADA KazumiHARADA commented Jun 9, 2019 •
edited
Loading

Description

  • Apply the method of fixLocalURLS before exporting to pdf.

Issue fixed

#3033

Type of changes

  • 🔘 Bug fix (Change that fixed an issue)
  • ⚪ Breaking change (Change that can cause existing functionality to change)
  • ⚪ Improvement (Change that improves the code. Maybe performance or development improvement)
  • ⚪ Feature (Change that adds new functionality)
  • ⚪ Documentation change (Change that modifies documentation. Maybe typo fixes)

Checklist:

  • 🔘 My code follows the project code style
  • ⚪ I have written test for my code and it has been tested
  • 🔘 All existing tests have been passed
  • 🔘 I have attached a screenshot/video to visualize my change if possible

Screenshot:

test

Tested:

MacOS Mojave (10.14.5)

@ZeroX-DG ZeroX-DG added the awaiting review ❇️ Pull request is awaiting a review. label Jun 10, 2019
ZeroX-DG
ZeroX-DG approved these changes Jun 15, 2019
View reviewed changes
Copy link
Member

@ZeroX-DG ZeroX-DG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

@ZeroX-DG ZeroX-DG added approved 👍 Pull request has been approved by sufficient reviewers. and removed awaiting review ❇️ Pull request is awaiting a review. labels Jun 15, 2019
@Rokt33r Rokt33r merged commit 3d7ab40 into BoostIO:master Jul 8, 2019
@Rokt33r Rokt33r added this to the v0.12.0 milestone Jul 8, 2019
@ZeroX-DG ZeroX-DG mentioned this pull request Jul 8, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ZeroX-DG ZeroX-DG ZeroX-DG approved these changes

+1 more reviewer

@Littleiii Littleiii Littleiii approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

approved 👍 Pull request has been approved by sufficient reviewers.

Projects

None yet

Milestone

v0.12.0

Development

Successfully merging this pull request may close these issues.

4 participants

@KazumiHARADA @ZeroX-DG @Littleiii @Rokt33r