Skip to content

Conversation

@KazumiHARADA
Copy link
Contributor

Description

  • Removed the default value of the customCSS on the ReactCodeMirror TAG in order to enable stored the CustomCSS value.
  • Moved the default value to the ConfigManger.js.

Issue fixed

#3041

Type of changes

  • 🔘 Bug fix (Change that fixed an issue)
  • ⚪ Breaking change (Change that can cause existing functionality to change)
  • ⚪ Improvement (Change that improves the code. Maybe performance or development improvement)
  • ⚪ Feature (Change that adds new functionality)
  • ⚪ Documentation change (Change that modifies documentation. Maybe typo fixes)

Checklist:

  • 🔘 My code follows the project code style
  • ⚪ I have written test for my code and it has been tested
  • 🔘 All existing tests have been passed
  • 🔘 I have attached a screenshot/video to visualize my change if possible

Screenshot

customcss

Tested

MacOS Mojave (10.14.5)

@KazumiHARADA KazumiHARADA changed the title [update] move default value of the customCSS field to ConfigManager Fix Custom CSS Disappears After Saving Jun 8, 2019
@ZeroX-DG
Copy link
Member

ZeroX-DG commented Jun 9, 2019

The /* Drop Your Custom CSS Code Here */ was there to fix this issue: #2789

With your current code, if the user clears the custom CSS editor, the old issue will appear again. Can you make the /* Drop Your Custom CSS Code Here */ into a placeholder or something?

@ZeroX-DG ZeroX-DG added the awaiting review ❇️ Pull request is awaiting a review. label Jun 9, 2019
@KazumiHARADA
Copy link
Contributor Author

I've modified inserting the default value to the custom CSS field when the field was saved empty.
Please check my code again.

Copy link
Member

@ZeroX-DG ZeroX-DG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

@ZeroX-DG ZeroX-DG added approved 👍 Pull request has been approved by sufficient reviewers. and removed awaiting review ❇️ Pull request is awaiting a review. labels Jun 15, 2019
@Rokt33r Rokt33r added this to the v0.12.0 milestone Jul 8, 2019
@Rokt33r Rokt33r merged commit b8de51b into BoostIO:master Jul 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved 👍 Pull request has been approved by sufficient reviewers.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants