Skip to content

fix gallery on windows #3027

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Rokt33r merged 2 commits into from
Jul 19, 2019
Merged

fix gallery on windows #3027

Rokt33r merged 2 commits into from
Jul 19, 2019

Conversation

@daiyam
Copy link
Contributor

@daiyam daiyam commented May 23, 2019

Description

This change fixes the gallery on windows.

Issue fixed

Type of changes

  • 🔘 Bug fix (Change that fixed an issue)
  • ⚪ Breaking change (Change that can cause existing functionality to change)
  • ⚪ Improvement (Change that improves the code. Maybe performance or development improvement)
  • ⚪ Feature (Change that adds new functionality)
  • ⚪ Documentation change (Change that modifies documentation. Maybe typo fixes)

Checklist:

  • 🔘 My code follows the project code style
  • 🔘 I have written test for my code and it has been tested
  • 🔘 All existing tests have been passed
  • ⚪ I have attached a screenshot/video to visualize my change if possible

@ZeroX-DG ZeroX-DG added the awaiting review ❇️ Pull request is awaiting a review. label May 25, 2019
ZeroX-DG
ZeroX-DG approved these changes May 25, 2019
View reviewed changes
Copy link
Member

@ZeroX-DG ZeroX-DG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

@ZeroX-DG ZeroX-DG added awaiting changes 🖊️ Pull request has been reviewed, but contributor needs to make changes. and removed awaiting review ❇️ Pull request is awaiting a review. labels May 25, 2019
@ZeroX-DG ZeroX-DG requested a review from Rokt33r May 25, 2019 23:24
@ZeroX-DG ZeroX-DG added the needs extra review 🔎 Pull request requires review from an additional reviewer. label May 25, 2019
@AWolf81
Copy link
Contributor

AWolf81 commented May 26, 2019 •
edited
Loading

LGTM.
Just one thing is not working as expected. The carousel thumb images for :storage files are not correctly displayed.

In the following screenshot there is no image in the lower right corner of the gallery. The second last image is correctly working because it is a https url.
grafik

It looks like the image url is not correct. Please have a look at the following screenshot
grafik

It could be a backslash escape issue. In the console I'm getting the following errors
grafik

@daiyam
Copy link
Contributor Author

daiyam commented May 26, 2019

@AWolf81 Thanks for catching the missing thumbnails...

@AWolf81
Copy link
Contributor

AWolf81 commented May 26, 2019

@daiyam you're welcome & thanks for the fix.
The thumbnails are working.

@Rokt33r Rokt33r merged commit 4e30d4b into BoostIO:master Jul 19, 2019
@Rokt33r Rokt33r added this to the v0.12.0 milestone Jul 19, 2019
@Rokt33r Rokt33r removed needs extra review 🔎 Pull request requires review from an additional reviewer. awaiting changes 🖊️ Pull request has been reviewed, but contributor needs to make changes. labels Jul 19, 2019
@Flexo013 Flexo013 mentioned this pull request Jul 24, 2019
Closed
@daiyam daiyam deleted the fix-image-gallery branch February 3, 2020 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ZeroX-DG ZeroX-DG ZeroX-DG approved these changes

@Rokt33r Rokt33r Awaiting requested review from Rokt33r

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

v0.12.0

Development

Successfully merging this pull request may close these issues.

4 participants

@daiyam @AWolf81 @ZeroX-DG @Rokt33r