Skip to content

Fix locale json format, add some translations for ja #2946

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Rokt33r merged 1 commit into from
Apr 2, 2019
Merged

Fix locale json format, add some translations for ja #2946

Rokt33r merged 1 commit into from
Apr 2, 2019

Conversation

@serima
Copy link
Contributor

@serima serima commented Mar 25, 2019 •
edited
Loading

Description

  • Fixed Locale JSON
    • Some JSON files mix tabs and indents
    • Resolve duplicate keys
  • Modify i18n key name Disabled to Spellcheck Disabled
    • The meaning is too broad with the word Disabled
  • Update locale/ja.json to localize

Issue fixed

No

Type of changes

  • ⚪️ Bug fix (Change that fixed an issue)
  • ⚪ Breaking change (Change that can cause existing functionality to change)
  • 🔘 Improvement (Change that improves the code. Maybe performance or development improvement)
  • ⚪ Feature (Change that adds new functionality)
  • ⚪ Documentation change (Change that modifies documentation. Maybe typo fixes)

Checklist:

  • 🔘 My code follows the project code style
  • 🔘 I have written test for my code and it has been tested
  • 🔘 All existing tests have been passed
  • 🔘 I have attached a screenshot/video to visualize my change if possible

@ZeroX-DG ZeroX-DG added the awaiting review ❇️ Pull request is awaiting a review. label Mar 26, 2019
ZeroX-DG
ZeroX-DG approved these changes Mar 26, 2019
View reviewed changes
Copy link
Member

@ZeroX-DG ZeroX-DG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉 Thank you for your contribution.

@ZeroX-DG ZeroX-DG added approved 👍 Pull request has been approved by sufficient reviewers. needs extra review 🔎 Pull request requires review from an additional reviewer. and removed awaiting review ❇️ Pull request is awaiting a review. labels Mar 26, 2019
@ZeroX-DG ZeroX-DG requested a review from Rokt33r March 26, 2019 22:33
@serima
Copy link
Contributor Author

serima commented Mar 27, 2019

Thank you for the review 👍

@Rokt33r Rokt33r removed needs extra review 🔎 Pull request requires review from an additional reviewer. approved 👍 Pull request has been approved by sufficient reviewers. labels Apr 2, 2019
@Rokt33r Rokt33r added this to the v0.11.15 milestone Apr 2, 2019
@Rokt33r Rokt33r merged commit 1be208d into BoostIO:master Apr 2, 2019
@serima serima deleted the feature/fix-i18n branch April 2, 2019 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ZeroX-DG ZeroX-DG ZeroX-DG approved these changes

@Rokt33r Rokt33r Awaiting requested review from Rokt33r

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

v0.11.16

Development

Successfully merging this pull request may close these issues.

3 participants

@serima @ZeroX-DG @Rokt33r