Skip to content

Conversation

@docbobo
Copy link
Contributor

@docbobo docbobo commented Mar 24, 2019

Description

When calling into markdown-it-plantuml an additional parameter was being passed that results in custom PlantUML server configs not being picked up. A few lines lower is similar code for dittaa (via PlantUML server) that is missing this parameter and that works correctly

Issue fixed

#2733

Type of changes

  • 🔘 Bug fix (Change that fixed an issue)
  • ⚪ Breaking change (Change that can cause existing functionality to change)
  • ⚪ Improvement (Change that improves the code. Maybe performance or development improvement)
  • ⚪ Feature (Change that adds new functionality)
  • ⚪ Documentation change (Change that modifies documentation. Maybe typo fixes)

Checklist:

  • 🔘 My code follows the project code style
  • ⚪ I have written test for my code and it has been tested
  • 🔘 All existing tests have been passed
  • ⚪ I have attached a screenshot/video to visualize my change if possible

@docbobo docbobo changed the title Removed erroneous parameter Removed erroneous parameter resulting in PlantUML server URL not being used Mar 24, 2019
@ZeroX-DG ZeroX-DG added the awaiting review ❇️ Pull request is awaiting a review. label Mar 25, 2019
@ZeroX-DG ZeroX-DG requested a review from Rokt33r March 25, 2019 00:04
@docbobo
Copy link
Contributor Author

docbobo commented Apr 7, 2019

@Rokt33r: this seems to be a trivial change, especially if you realize that code similar to this on line 197 is already working.

@Rokt33r Rokt33r merged commit 7f55fc4 into BoostIO:master Apr 12, 2019
@Rokt33r
Copy link
Member

Rokt33r commented Apr 12, 2019

@docbobo Sorry for my late response... 😢

@Rokt33r Rokt33r removed the awaiting review ❇️ Pull request is awaiting a review. label Apr 12, 2019
@Rokt33r Rokt33r added this to the v0.11.15 milestone Apr 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants