Skip to content

Spellcheck dropdown fix #2926

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Rokt33r merged 2 commits into from
Apr 15, 2019
Merged

Spellcheck dropdown fix #2926

Rokt33r merged 2 commits into from
Apr 15, 2019

Conversation

@MiloTodt
Copy link
Contributor

@MiloTodt MiloTodt commented Mar 14, 2019 •
edited
Loading

Description

Modification of the CodeEditor.styl to remove spellcheck squiggle from the dropdown menu itself.

Issue fixed

Before there was a squiggle present under all options for selecting language of spell checker:

Before:

image

After:

image

Type of changes

  • ✔️ Bug fix (Change that fixed an issue)
  • ⚪ Breaking change (Change that can cause existing functionality to change)
  • ⚪ Improvement (Change that improves the code. Maybe performance or development improvement)
  • ⚪ Feature (Change that adds new functionality)
  • ⚪ Documentation change (Change that modifies documentation. Maybe typo fixes)

Checklist:

  • ✔️ My code follows the project code style
  • ⚪ I have written test for my code and it has been tested
  • ✔️ All existing tests have been passed
  • ✔️ I have attached a screenshot/video to visualize my change if possible

Milo Todt and others added 2 commits March 4, 2019 10:03
@ZeroX-DG ZeroX-DG added the awaiting review ❇️ Pull request is awaiting a review. label Mar 16, 2019
ZeroX-DG
ZeroX-DG approved these changes Apr 13, 2019
View reviewed changes
Copy link
Member

@ZeroX-DG ZeroX-DG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

@ZeroX-DG ZeroX-DG added approved 👍 Pull request has been approved by sufficient reviewers. and removed awaiting review ❇️ Pull request is awaiting a review. labels Apr 13, 2019
@Rokt33r Rokt33r removed the approved 👍 Pull request has been approved by sufficient reviewers. label Apr 15, 2019
@Rokt33r Rokt33r added this to the v0.11.15 milestone Apr 15, 2019
@Rokt33r Rokt33r merged commit 0a72acd into BoostIO:master Apr 15, 2019
@MiloTodt MiloTodt deleted the spellcheck_dropdown_fix branch April 15, 2019 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ZeroX-DG ZeroX-DG ZeroX-DG approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

v0.11.16

Development

Successfully merging this pull request may close these issues.

3 participants

@MiloTodt @ZeroX-DG @Rokt33r