Skip to content

Fetch page title when paste valid markdown title with one valid URL #2908

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Rokt33r merged 4 commits into from
Apr 15, 2019
Merged

Fetch page title when paste valid markdown title with one valid URL #2908

Rokt33r merged 4 commits into from
Apr 15, 2019

Conversation

@abnersajr
Copy link
Contributor

@abnersajr abnersajr commented Feb 28, 2019

Now you can paste a valid markdown title with a link, eg: # https://boostnote.io and it gets the right page title.

boostnote

Issue fixed

#2907

Type of changes

  • ⚪ Bug fix (Change that fixed an issue)
  • ⚪ Breaking change (Change that can cause existing functionality to change)
  • ⚪ Improvement (Change that improves the code. Maybe performance or development improvement)
  • 🔘 Feature (Change that adds new functionality)
  • ⚪ Documentation change (Change that modifies documentation. Maybe typo fixes)

Checklist:

  • 🔘 My code follows the project code style
  • 🔘 I have written test for my code and it has been tested
  • 🔘 All existing tests have been passed
  • 🔘 I have attached a screenshot/video to visualize my change if possible

boniattirodrigo
boniattirodrigo reviewed Feb 28, 2019
View reviewed changes
@ZeroX-DG ZeroX-DG added the awaiting review ❇️ Pull request is awaiting a review. label Feb 28, 2019
@ZeroX-DG
Copy link
Member

ZeroX-DG commented Mar 24, 2019

Can you fix the conflict?

@abnersajr
Copy link
Contributor Author

abnersajr commented Mar 24, 2019

@ZeroX-DG conflicts solved.

ZeroX-DG
ZeroX-DG approved these changes Mar 24, 2019
View reviewed changes
Copy link
Member

@ZeroX-DG ZeroX-DG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

@ZeroX-DG ZeroX-DG added approved 👍 Pull request has been approved by sufficient reviewers. and removed awaiting review ❇️ Pull request is awaiting a review. labels Mar 24, 2019
@Rokt33r Rokt33r removed the approved 👍 Pull request has been approved by sufficient reviewers. label Apr 15, 2019
@Rokt33r Rokt33r added this to the v0.11.15 milestone Apr 15, 2019
@Rokt33r Rokt33r merged commit 038b87c into BoostIO:master Apr 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ZeroX-DG ZeroX-DG ZeroX-DG approved these changes

+1 more reviewer

@boniattirodrigo boniattirodrigo boniattirodrigo left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

v0.11.16

Development

Successfully merging this pull request may close these issues.

4 participants

@abnersajr @ZeroX-DG @boniattirodrigo @Rokt33r