Refactor code editor by moving the expand snippet out to a separate file #2864
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ZeroX-DG
added
approved 👍
ZeroX-DG
changed the title
Rokt33r
removed
needs extra review 🔎
|
The master is crashing? |
seanders
reviewed
Mar 22, 2019
| this.snippets = [] | ||
| this.expandSnippet = this.expandSnippet.bind(this) | ||
| this.init = this.init.bind(this) | ||
| this.assignSnippet = this.assignSnippet.bind(this) |
There was a problem hiding this comment.
Looks like this is a typo. It's causing startup to fail on my local machine. This likely should be:
this.assignSnippets = this.assignSnippets.bind(this)
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR attempt to refactor the CodeEditor component by moving the CodeMirror language list and expand snippet feature out to a separated file
Refactor information