Skip to content

fix bug when add tag, disappear note. #1363

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
kazup01 merged 1 commit into from
Jan 4, 2018
Merged

fix bug when add tag, disappear note. #1363

kazup01 merged 1 commit into from
Jan 4, 2018

Conversation

@sosukesuzuki
Copy link
Member

@sosukesuzuki sosukesuzuki commented Jan 4, 2018

fix #1357

@BoostnoteBot
Copy link
Collaborator

BoostnoteBot commented Jan 4, 2018

Be sure to be changed browser/main/Detail/SnippetNoteDetail.js.

@sosukesuzuki sosukesuzuki changed the title split update functions fix bug when add tag, disappear note. Jan 4, 2018
@kazup01 kazup01 self-requested a review January 4, 2018 10:57
kazup01
kazup01 approved these changes Jan 4, 2018
View reviewed changes
Copy link
Member

@kazup01 kazup01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kazup01 kazup01 merged commit 4b85e3e into master Jan 4, 2018
@kazup01 kazup01 deleted the fix-note-disppaer-bug branch January 4, 2018 10:57
@kazup01
Copy link
Member

kazup01 commented Jan 4, 2018

Merged. Thanks @sosukesuzuki !

@kazup01 kazup01 mentioned this pull request Jan 4, 2018
Closed
@elazar elazar mentioned this pull request Jan 4, 2018
Closed
@sosukesuzuki sosukesuzuki mentioned this pull request Jan 11, 2018
Closed
@Rokt33r Rokt33r mentioned this pull request Jan 13, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kazup01 kazup01 kazup01 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Entire notes disappeared after adding/removing tags

4 participants

@sosukesuzuki @BoostnoteBot @kazup01