fixed opening finder on Windows and Linux #1302
Merged
+2
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixes #1291 - tested on Ubuntu Linux Mate and Windows 10
sosukesuzuki
requested changes
Dec 19, 2017
Member
sosukesuzuki
left a comment
sosukesuzuki
left a comment
There was a problem hiding this comment.
Maybe you edited this code on Windows, so line feed code has become CRLF.
please fix it.
sosukesuzuki
approved these changes
Dec 23, 2017
Member
|
@mslourens ! |
Member
|
Hi @mslourens , thanks for your contribution. I can open a finder in master branch, but I can not open it in this one. Could you investigate it? environment Windows 10 |
kazup01
added
awaiting changes 🖊️
Contributor
Author
|
On my Windows 10 laptop is the other way around: only with my changes am I able to open the Finder window. |
Member
|
Merged. Thanks @mslourens 😊 Happy new year! |
kazup01
added
next release (v0.8.20)
and removed
awaiting changes 🖊️
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1291 - tested on Ubuntu Linux Mate and Windows 10