first attempt to export html #1256
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Be sure to be changed |
Member
|
Awesome! |
Contributor
Author
|
What do you mean by 'share notes on the web'? The feature request was about
exporting notes to HTML (including images and other references), so what
would this export to the web look like? Where on the web would you export
it?
|
Member
|
I understand this pull request. I think that it would be better if could display the notes on web page as a future plan. |
kazup01
added
awaiting review ❇️
sota1235
reviewed
Dec 13, 2017
| } | ||
|
|
||
| handleSaveAsHtml () { | ||
| this.exportAsDocument('html', function formatHtml (value) { |
Contributor
There was a problem hiding this comment.
you don't need to name function. plz just write such as (value) => this.refs.root.contentWindow.document.documentElement.outerHTML
sota1235
reviewed
Dec 13, 2017
| ], | ||
| properties: ['openFile', 'createDirectory'] | ||
| } | ||
| var value = formatter ? formatter.call(this, this.props.value) : this.props.value |
sota1235
reviewed
Dec 13, 2017
lib/main-menu.js
Outdated
| } | ||
| }, | ||
| { | ||
| label: 'Html (.html)', |
sota1235
suggested changes
Dec 13, 2017
Contributor
sota1235
left a comment
sota1235
left a comment
There was a problem hiding this comment.
plz confirm my comments
sota1235
added
next release (v0.8.20)
and removed
awaiting review ❇️
Member
|
Merged. Thanks for your contribution @mslourens ! |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
minimum viable implementation of #1233, please let me know what you think.