Skip to content

fixed global styles #1241

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
kazup01 merged 3 commits into from
Dec 6, 2017
Merged

fixed global styles #1241

kazup01 merged 3 commits into from
Dec 6, 2017

Conversation

@mslourens
Copy link
Contributor

@mslourens mslourens commented Dec 5, 2017

fixes #1240

@BoostnoteBot
Copy link
Collaborator

BoostnoteBot commented Dec 5, 2017

Please make sure to be pasted screenshots of all your changes.

@mslourens
Copy link
Contributor Author

mslourens commented Dec 5, 2017

This is how it looks like now:
image

@kazup01 kazup01 self-requested a review December 5, 2017 08:20
kazup01
kazup01 reviewed Dec 5, 2017
View reviewed changes
.gitignore
/secret
*.log
.vscode
.idea
Copy link
Member

@kazup01 kazup01 Dec 5, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that .vscode and .idea are unnecessary. Could you remove them?

Copy link
Contributor Author

@mslourens mslourens Dec 5, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just added them, because I use both editors and always have to be careful not to commit those IDE specific files. Is it a real problem that we add them here?

Copy link
Member

@kazup01 kazup01 Dec 5, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I understand your opinion, but I think that we should merge only generally code (not only for us) because Boostnote is open source.

Copy link
Member

@sosukesuzuki sosukesuzuki Dec 5, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't think it is unnecessary to add .idea and .vscode into .gitignore. However, if many contributors want it, we'll add it. 😄
And, This pull request is "fixed global styles". could you create new pull request for add it.?🙏

@kazup01 kazup01 added the awaiting review ❇️ Pull request is awaiting a review. label Dec 5, 2017
@mslourens
Copy link
Contributor Author

mslourens commented Dec 5, 2017

I removed the gitignore changes and created a new PR with these changes: #1242

@kazup01
Copy link
Member

kazup01 commented Dec 5, 2017

Thanks @mslourens ! I will check this tomorrow.

kazup01
kazup01 approved these changes Dec 6, 2017
View reviewed changes
Copy link
Member

@kazup01 kazup01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kazup01 kazup01 merged commit e3c6f04 into BoostIO:master Dec 6, 2017
@kazup01
Copy link
Member

kazup01 commented Dec 6, 2017

Merged. Thanks @mslourens !

@kazup01 kazup01 added next release (v0.8.19) and removed awaiting review ❇️ Pull request is awaiting a review. Next Release labels Dec 6, 2017
@kohei-takata kohei-takata mentioned this pull request Dec 23, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sosukesuzuki sosukesuzuki sosukesuzuki left review comments

@kazup01 kazup01 kazup01 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

global.styl not working correctly

4 participants

@mslourens @BoostnoteBot @kazup01 @sosukesuzuki