Fixbug react code mirror #1218
Merged
Fixbug react code mirror #1218
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sosukesuzuki
approved these changes
Dec 2, 2017
Member
sosukesuzuki
left a comment
sosukesuzuki
left a comment
There was a problem hiding this comment.
About a year ago, it was me who implemented it.
I was aware of the bug, but I could not fix it.
Thank you! LGTM !! 😄 👍
Member
|
Thank you @PaulRosset ;) |
kazup01
added
next release (v0.8.18)
and removed
awaiting review ❇️
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi :)
React-codemirror library produced a bug with the
loadModule()method.The mini editor inside the UI tab was not highlighted when the component was mount for the first time due to an error with react-codemirror.
