Skip to content

Conversation

@jhemelhof
Copy link
Contributor

Reference
Fixes issues #916 and #1074

Description
This pull request adds an option to open 'Preferences' to the menu. For Windows/OS X this is in the 'Boostnote' menu, for Linux in the 'File' menu.

Screenshot/GIF
peek 2017-11-09 09-49

@kazup01 kazup01 requested a review from sosukesuzuki November 9, 2017 09:02
@kazup01 kazup01 added the awaiting review ❇️ Pull request is awaiting a review. label Nov 9, 2017
@kazup01
Copy link
Member

kazup01 commented Nov 9, 2017

Thank you @clone1612 !

@kazup01 kazup01 requested review from sota1235 and removed request for sosukesuzuki November 9, 2017 09:46
Copy link
Contributor

@sota1235 sota1235 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me
@kazup01 Can you confirm behavior on all platforms?

@kazup01 kazup01 merged commit 2ec5238 into BoostIO:master Nov 9, 2017
@kazup01
Copy link
Member

kazup01 commented Nov 9, 2017

Thank you for your contribution @clone1612 !

@kazup01 kazup01 removed the awaiting review ❇️ Pull request is awaiting a review. label Nov 9, 2017
@jhemelhof jhemelhof deleted the openPreferences branch November 9, 2017 14:11
@kohei-takata kohei-takata mentioned this pull request Nov 25, 2017
@kazup01
Copy link
Member

kazup01 commented Nov 25, 2017

Hi @clone1612 , I wrote your pull request to release note.
Thank you :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants