From 549c289f81964f7b6938cdd0a108e2253c86d263 Mon Sep 17 00:00:00 2001 From: Benjamin Tran Date: Wed, 26 Apr 2017 19:03:35 -0700 Subject: [PATCH] fixes #504 scrollbar no longer appears above modal. Edit NoteList style properties on modal component. Remove overflow to hide scrollbar on modal open. --- browser/main/lib/modal.js | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/browser/main/lib/modal.js b/browser/main/lib/modal.js index d5bbaeb17..1964d52e7 100644 --- a/browser/main/lib/modal.js +++ b/browser/main/lib/modal.js @@ -15,6 +15,9 @@ class ModalBase extends React.Component { close () { if (modalBase != null) modalBase.setState({component: null, componentProps: null, isHidden: true}) + // Toggle overflow style on NoteList + let list = document.querySelector('.NoteList__list___browser-main-NoteList-') + list.style.overflow = 'auto' } render () { @@ -37,7 +40,9 @@ let modalBase = ReactDOM.render(, el) export function openModal (component, props) { if (modalBase == null) { return } - + // Hide scrollbar by removing overflow when modal opens + let list = document.querySelector('.NoteList__list___browser-main-NoteList-') + list.style.overflow = 'hidden' document.body.setAttribute('data-modal', 'open') modalBase.setState({component: component, componentProps: props, isHidden: false}) }