From 0d31d0a5e0022499ecee698f7a1b98f1a7f25b3d Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Nguy=E1=BB=85n=20Vi=E1=BB=87t=20H=C6=B0ng?= Date: Sun, 21 Apr 2019 11:10:29 +1200 Subject: [PATCH 1/2] fixed empty link point to main file --- browser/components/MarkdownPreview.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/browser/components/MarkdownPreview.js b/browser/components/MarkdownPreview.js index 771392c64..8140058be 100755 --- a/browser/components/MarkdownPreview.js +++ b/browser/components/MarkdownPreview.js @@ -1000,7 +1000,7 @@ export default class MarkdownPreview extends React.Component { e.preventDefault() e.stopPropagation() - const href = e.target.href + const href = e.target.getAttribute('href') const linkHash = href.split('/').pop() const regexNoteInternalLink = /main.html#(.+)/ From 51c178fc38ce148d54432915b1ba1fb538b59638 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Nguy=E1=BB=85n=20Vi=E1=BB=87t=20H=C6=B0ng?= Date: Sun, 21 Apr 2019 11:11:35 +1200 Subject: [PATCH 2/2] added check empty for safety reason --- browser/components/MarkdownPreview.js | 2 ++ 1 file changed, 2 insertions(+) diff --git a/browser/components/MarkdownPreview.js b/browser/components/MarkdownPreview.js index 8140058be..db09bc60b 100755 --- a/browser/components/MarkdownPreview.js +++ b/browser/components/MarkdownPreview.js @@ -1003,6 +1003,8 @@ export default class MarkdownPreview extends React.Component { const href = e.target.getAttribute('href') const linkHash = href.split('/').pop() + if (!href) return + const regexNoteInternalLink = /main.html#(.+)/ if (regexNoteInternalLink.test(linkHash)) { const targetId = mdurl.encode(linkHash.match(regexNoteInternalLink)[1])