Skip to content

Commit 78c8c67

Browse files
authored
Merge pull request #7 from donghwikim2/copilot/sub-pr-2-one-more-time
Address formatting and ordering feedback on ECS data fetchers
2 parents f356d42 + 20d53aa commit 78c8c67

File tree

2 files changed

+7
-10
lines changed

2 files changed

+7
-10
lines changed

connector/aws/ecs/src/main/java/com/blazebit/query/connector/aws/ecs/AwsContainerDefinition.java

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,12 +6,10 @@
66

77
import software.amazon.awssdk.services.ecs.model.ContainerDefinition;
88

9-
109
/**
1110
* @author Donghwi Kim
1211
* @since 1.0.0
1312
*/
14-
1513
public record AwsContainerDefinition(
1614
String taskDefinitionArn, String name, ContainerDefinition payload
1715
) {

examples/app/src/main/java/com/blazebit/query/app/Main.java

Lines changed: 7 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -276,9 +276,9 @@ public static void main(String[] args) throws Exception {
276276
queryContextBuilder.registerSchemaObjectAlias( AwsRepository.class, "AwsRepository" );
277277
// ECS
278278
queryContextBuilder.registerSchemaObjectAlias( AwsCluster.class, "AwsCluster" );
279+
queryContextBuilder.registerSchemaObjectAlias( AwsContainerDefinition.class, "AwsContainerDefinition" );
279280
queryContextBuilder.registerSchemaObjectAlias( AwsService.class, "AwsService" );
280281
queryContextBuilder.registerSchemaObjectAlias( AwsTaskDefinition.class, "AwsTaskDefinition" );
281-
queryContextBuilder.registerSchemaObjectAlias( AwsContainerDefinition.class, "AwsContainerDefinition" );
282282
queryContextBuilder.registerSchemaObjectAlias( AwsTaskSet.class, "AwsTaskSet" );
283283
// ELB
284284
queryContextBuilder.registerSchemaObjectAlias( AwsLoadBalancer.class, "AwsLoadBalancer" );
@@ -521,6 +521,12 @@ private static void testAws(QuerySession session) {
521521
System.out.println("AwsClusters");
522522
print(awsClusterResult);
523523

524+
TypedQuery<Object[]> awsContainerDefinitionQuery = session.createQuery(
525+
"select f.* from AwsContainerDefinition f" );
526+
List<Object[]> awsContainerDefinitionResult = awsContainerDefinitionQuery.getResultList();
527+
System.out.println("AwsContainerDefinitions");
528+
print(awsContainerDefinitionResult);
529+
524530
TypedQuery<Object[]> awsServiceQuery = session.createQuery(
525531
"select f.* from AwsService f" );
526532
List<Object[]> awsServiceResult = awsServiceQuery.getResultList();
@@ -533,19 +539,12 @@ private static void testAws(QuerySession session) {
533539
System.out.println("AwsTaskDefinitions");
534540
print(awsTaskDefinitionResult);
535541

536-
TypedQuery<Object[]> awsContainerDefinitionQuery = session.createQuery(
537-
"select f.* from AwsContainerDefinition f" );
538-
List<Object[]> awsContainerDefinitionResult = awsContainerDefinitionQuery.getResultList();
539-
System.out.println("AwsContainerDefinitions");
540-
print(awsContainerDefinitionResult);
541-
542542
TypedQuery<Object[]> awsTaskSetQuery = session.createQuery(
543543
"select f.* from AwsTaskSet f" );
544544
List<Object[]> awsTaskSetResult = awsTaskSetQuery.getResultList();
545545
System.out.println("AwsTaskSets");
546546
print(awsTaskSetResult);
547547

548-
549548
// ELB
550549
TypedQuery<Object[]> awsLoadBalancerQuery = session.createQuery(
551550
"select f.* from AwsLoadBalancer f" );

0 commit comments

Comments
 (0)