PR Review Club: Bitcoin-Core v29.0

[yuvicc]

Session Details

Date: 24-04-2024
Time: IST 19:00 (UTC 13:30)
Link: Release Notes
Difficulty: Easy

Motivation:

Bitcoin-core v29.0 has been released and we will be reviewing the changes in v29.0 in the upcoming Review Club.

Some of the major changes include:

• Build system, autotools to CMake
• UPnP support has been dropped with PCP and NAT/PMP as fallback
• Fix of max block weight bug
• RPC changes such as testmempoolaccept will give more verbose details, getdescriptoractivity is the new rpc, etc.

Pre-requisites:

• Clone bitcoin-core v29.0 from releases.
• Build bitcoin-core v29.0 using cmake.

Questions:

• Why was the build system migrated from Autotools to CMake?
• Why the support for upnp was dropped?
• What the extra field we would see in testmempoolaccept rpc?

Learnings:

git
c++
cmake

[yuvicc]

Answers to questions

• The build system was migrated to CMake as because it was a big burden to maintain Autotools and also it's hardly maintained by 1-2 developers wheres CMake is new and it has low maintenance burden.
• UPnP support was dropped due to critical vulnerability present and caused bitcoin node to crash.
• reject-details