Replace space with - in generated ODBC MSI file name

Attempt

Author: alinaliBQ

.github/workflows/cpp_extra.yml

@@ -455,12 +455,12 @@ jobs:
         uses: actions/upload-artifact@v6
         with:
           name: flight-sql-odbc-msi-installer
-          path: build/cpp/Apache Arrow Flight SQL ODBC-*-win64.msi
+          path: build/cpp/Apache-Arrow-Flight-SQL-ODBC-*-win64.msi
           if-no-files-found: error
       - name: Install ODBC MSI
         run: |
           cd build/cpp
-          $odbc_msi = Get-ChildItem -Filter "Apache Arrow Flight SQL ODBC-*-win64.msi"
+          $odbc_msi = Get-ChildItem -Filter "Apache-Arrow-Flight-SQL-ODBC-*-win64.msi"
           if (-not $odbc_msi) {
             Write-Error "ODBC MSI not found"
             exit 1
@@ -474,7 +474,7 @@ jobs:
           }
       - name: Check ODBC DLL installation
         run: |
-          $dirs = Get-ChildItem "C:\Program Files" -Directory -Filter "Apache Arrow Flight SQL ODBC*"
+          $dirs = Get-ChildItem "C:\Program Files" -Directory -Filter "Apache-Arrow-Flight-SQL-ODBC*"
 
           foreach ($dir in $dirs) {
             $bin = Join-Path $dir.FullName "bin"
@@ -580,7 +580,7 @@ jobs:
         run: |
           gh release upload ${GITHUB_REF_NAME} \
             --clobber \
-            "Apache Arrow Flight SQL ODBC"-*-win64.msi
+            "Apache-Arrow-Flight-SQL-ODBC"-*-win64.msi
 
   report-extra-cpp:
     if: github.event_name == 'schedule' && always()

cpp/src/arrow/flight/sql/odbc/CMakeLists.txt

@@ -106,6 +106,8 @@ if(ARROW_FLIGHT_SQL_ODBC_INSTALLER)
   set(CPACK_PACKAGE_VERSION_PATCH ${ODBC_PACKAGE_VERSION_PATCH})
 
   set(CPACK_PACKAGE_NAME ${ODBC_PACKAGE_NAME})
+  # Make sure the MSI name contains only hyphens, not spaces
+  string(REPLACE " " "-" CPACK_PACKAGE_NAME "${CPACK_PACKAGE_NAME}")
   set(CPACK_PACKAGE_VENDOR ${ODBC_PACKAGE_VENDOR})
   set(CPACK_PACKAGE_DESCRIPTION_SUMMARY "Apache Arrow Flight SQL ODBC Driver")
   set(CPACK_PACKAGE_CONTACT "dev@arrow.apache.org")

dev/release/04-binary-download.sh

@@ -54,6 +54,6 @@ gh release download "${tag}" \
   --pattern "centos-*.tar.gz" \
   --pattern "debian-*.tar.gz" \
   --pattern "ubuntu-*.tar.gz" \
-  --pattern "Apache Arrow Flight SQL ODBC-*-win64.msi" \
+  --pattern "Apache-Arrow-Flight-SQL-ODBC-*-win64.msi" \
   --repo "${REPOSITORY:-apache/arrow}" \
   --skip-existing

dev/release/05-binary-upload.sh

@@ -111,7 +111,7 @@ if [ "${UPLOAD_DOCS}" -gt 0 ]; then
 fi
 if [ "${UPLOAD_ODBC}" -gt 0 ]; then
   upload_to_github_release odbc \
-    "${ARROW_ARTIFACTS_DIR}"/"Apache Arrow Flight SQL ODBC"-*-win64.msi
+    "${ARROW_ARTIFACTS_DIR}"/"Apache-Arrow-Flight-SQL-ODBC"-*-win64.msi
 fi
 if [ "${UPLOAD_PYTHON}" -gt 0 ]; then
   upload_to_github_release python \