Skip to content

[Refactoring] making the code more Pythonic #570

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 12, 2022
Merged

[Refactoring] making the code more Pythonic #570

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ea9f310
Using with stmt
maldil Aug 7, 2022
fab2737
Using with stmt
maldil Aug 7, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions bindsnet/environment/dot_simulator.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -436,9 +436,8 @@ def render(self):

# Write to file if requested.
if self.write2F:
f = open(self.filename, "ab")
np.savetxt(f, temp, delimiter=",")
f.close()
with open(self.filename, "ab") as f:
np.savetxt(f, temp, delimiter=",")

# Print as pandas dataframe if requested.
if self.pandas:
Expand Down
16 changes: 7 additions & 9 deletions examples/dotTracing/dot_tracing.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -161,9 +161,8 @@ def runSimulator(net, env, spikes, episodes, gran=100, rfname="", pfname=""):

# Save rewards thus far to file
if rfname != "":
f = open(rfname, "ab")
np.savetxt(f, rewards, delimiter=",", fmt="%.6f")
f.close()
with open(rfname, "ab") as f:
np.savetxt(f, rewards, delimiter=",", fmt="%.6f")

spikes_ = {layer: spikes[layer].get("s").view(gran, -1) for layer in spikes}
spike_ims, spike_axes = plot_spikes(spikes_, ims=spike_ims, axes=spike_axes)
Expand All @@ -181,12 +180,11 @@ def runSimulator(net, env, spikes, episodes, gran=100, rfname="", pfname=""):
print(f"Episode {ep} total reward:{total_reward}")
# Save intcercepts thus far to file
if pfname != "":
f = open(pfname, "a+")
if 0 < ep:
f.write("," + str(intercepts))
else:
f.write(str(intercepts))
f.close()
with open(pfname, "a+") as f:
if 0 < ep:
f.write("," + str(intercepts))
else:
f.write(str(intercepts))

# Cycle output files every 10000 iterations
if ep % fcycle == 0:
Expand Down