helpers: Improve pull_and_update_inner by restoring old pwd

Author: Noah Gorny

lib/helpers.bash

@@ -195,6 +195,9 @@ _bash-it-update-stable() {
 }
 
 _bash-it_pull_and_update_inner() {
+  _param '1: Which branch to checkout to'
+  _param '2: Which type of version we are using'
+  _param '3: Old pwd to restore'
   git checkout "$1" &> /dev/null
   if [[ $? -eq 0 ]]; then
     echo "Bash-it successfully updated."
@@ -203,7 +206,9 @@ _bash-it_pull_and_update_inner() {
     _bash-it-migrate
     echo ""
     echo "All done, enjoy!"
-    bash-it restart
+    # Don't forget to restore the original pwd!
+    cd "$3" &> /dev/null
+    _bash-it-restart
   else
     echo "Error updating Bash-it, please, check if your Bash-it installation folder (${BASH_IT}) is clean."
   fi
@@ -284,12 +289,12 @@ _bash-it-update-() {
 
     if [[ $silent ]]; then
       echo "Updating to ${TARGET}($(git log -1 --format=%h "${TARGET}"))..."
-      _bash-it_pull_and_update_inner $TARGET $version
+      _bash-it_pull_and_update_inner $TARGET $version $old_pwd
     else
       read -e -n 1 -p "Would you like to update to ${TARGET}($(git log -1 --format=%h "${TARGET}"))? [Y/n] " RESP
       case $RESP in
         [yY]|"")
-          _bash-it_pull_and_update_inner $TARGET $version
+          _bash-it_pull_and_update_inner $TARGET $version $old_pwd
           ;;
         [nN])
           echo "Not updating…"