Fix artifact point extraction going into negatives (#36642)

EmoGarbage404 · web-flow · commit cc7df12996a8 · 2025-04-16T23:14:17.000-04:00
diff --git a/Content.Server/Xenoarchaeology/Equipment/ArtifactAnalyzerSystem.cs b/Content.Server/Xenoarchaeology/Equipment/ArtifactAnalyzerSystem.cs
@@ -39,7 +39,8 @@ private void OnExtractButtonPressed(Entity<AnalysisConsoleComponent> ent, ref An
             sumResearch += research;
         }
 
-        if (sumResearch == 0)
+        // 4-16-25: It's a sad day when a scientist makes negative 5k research
+        if (sumResearch <= 0)
             return;
 
         _research.ModifyServerPoints(server.Value, sumResearch, serverComponent);
diff --git a/Content.Shared/Xenoarchaeology/Artifact/SharedXenoArtifactSystem.Node.cs b/Content.Shared/Xenoarchaeology/Artifact/SharedXenoArtifactSystem.Node.cs
@@ -163,7 +163,7 @@ public int GetResearchValue(Entity<XenoArtifactNodeComponent> ent)
         if (ent.Comp.Locked)
             return 0;
 
-        return ent.Comp.ResearchValue - ent.Comp.ConsumedResearchValue;
+        return Math.Max(0, ent.Comp.ResearchValue - ent.Comp.ConsumedResearchValue);
     }
 
     /// <summary>

Original file line number	Diff line number	Diff line change
`@@ -39,7 +39,8 @@ private void OnExtractButtonPressed(Entity<AnalysisConsoleComponent> ent, ref An`
`39`	`39`	`sumResearch += research;`
`40`	`40`	`}`
`41`	`41`
`42`		`- if (sumResearch == 0)`
	`42`	`+ // 4-16-25: It's a sad day when a scientist makes negative 5k research`
	`43`	`+ if (sumResearch <= 0)`
`43`	`44`	`return;`
`44`	`45`
`45`	`46`	`_research.ModifyServerPoints(server.Value, sumResearch, serverComponent);`
Original file line number	Diff line number	Diff line change
`@@ -163,7 +163,7 @@ public int GetResearchValue(Entity<XenoArtifactNodeComponent> ent)`
`163`	`163`	`if (ent.Comp.Locked)`
`164`	`164`	`return 0;`
`165`	`165`
`166`		`- return ent.Comp.ResearchValue - ent.Comp.ConsumedResearchValue;`
	`166`	`+ return Math.Max(0, ent.Comp.ResearchValue - ent.Comp.ConsumedResearchValue);`
`167`	`167`	`}`
`168`	`168`
`169`	`169`	`/// <summary>`