#336 disabled warnings in two files pertaining to V8 in order to enable building with warnings treated as errors. Ideally, we would want to fix these warnings rather than just turn them off, but there are complications in both cases.
- In
js_native_api_v8.cc, that file may also exist in other repositories and for that reason we may wish to be cautious about introducing changes to it.
- In
AppRuntimeV8.cpp, the errors I turned off were coming from files inside the V8 NuGet package, over which we have no direct control whatsoever, so I'm not sure there's a better way for us to handle that situation than to simply turn the errors off.
#336 disabled warnings in two files pertaining to V8 in order to enable building with warnings treated as errors. Ideally, we would want to fix these warnings rather than just turn them off, but there are complications in both cases.
js_native_api_v8.cc, that file may also exist in other repositories and for that reason we may wish to be cautious about introducing changes to it.AppRuntimeV8.cpp, the errors I turned off were coming from files inside the V8 NuGet package, over which we have no direct control whatsoever, so I'm not sure there's a better way for us to handle that situation than to simply turn the errors off.