Check for null in PrepareAuthorityInstanceForMsal #3338
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pmaytak
approved these changes
Apr 19, 2025
neha-bhargava
approved these changes
Apr 25, 2025
jennyf19
approved these changes
Apr 28, 2025
jmprieur
reviewed
Apr 29, 2025
| { | ||
| if (string.IsNullOrEmpty(Instance)) | ||
| { | ||
| return; |
Collaborator
There was a problem hiding this comment.
this is curing a symptom, not the root cause, which is that the authentication scheme is likely to be wrong, or the developer didn't provide Instance/TenantId or Authority
Maybe we should just throw a meaningful exception instead?
"Intance+TenantId or Authority not provided for authentication scheme/named options {named options}
Collaborator
There was a problem hiding this comment.
Sorry, I had forgotten to submit the review ... days ago
Contributor
Author
There was a problem hiding this comment.
Fair point, we can revert this and throw a meaningful exception.
keegan-caruso
added a commit
that referenced
this pull request
Apr 30, 2025
This reverts commit c33e90f.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check for null in PrepareAuthorityInstanceForMsal
Description
Check for null in PrepareAuthorityInstanceForMsal
Fixes #3337