Invalid comparisons in prop and csproj files

[keegan-caruso]

Microsoft.Identity.Web Library

Microsoft.Identity.Web

Microsoft.Identity.Web version

main branch

Web app

Not Applicable

Web API

Not Applicable

Token cache serialization

Not Applicable

Description

For example:

microsoft-identity-web/Directory.Build.props

Line 47 in 690cea4

<PropertyGroup Condition="'$(TargetFrameworkIdentifier)' == 'NET6_0_OR_GREATER'">

This is incorrect. To check for something like this, use this syntax:

  <PropertyGroup Condition="$([MSBuild]::IsTargetFrameworkCompatible('$(TargetFramework)', 'net8.0'))">

This is part of why the library is not AOT compatible.

A search over the repo shows a few of these errors: https://github.com/search?q=repo%3AAzureAD%2Fmicrosoft-identity-web%20TargetFrameworkIdentifier&type=codeNA

Reproduction steps

NA

Error message

No response

Id Web logs

No response

Relevant code snippets

NA

Regression

No response

Expected behavior

Comparisons should be valid.