Skip to content

Remove some flaky tests that were just an overkill #5486

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 19, 2025
Merged

Remove some flaky tests that were just an overkill #5486

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
88 changes: 0 additions & 88 deletions ...icrosoft.Identity.Test.Integration.netcore/SeleniumTests/DeviceCodeFlowIntegrationTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,38 +53,6 @@ public async Task SilentTokenAfterDeviceCodeFlowWithBrokerTestAsync()
await AcquireTokenSilentAfterDeviceCodeFlowWithBrokerAsync(labResponse, "aad user").ConfigureAwait(false);
}

[TestMethod]
[Timeout(2 * 60 * 1000)] // 2 min timeout
[TestCategory(TestCategories.Arlington)]
public async Task ArlingtonDeviceCodeFlowTestAsync()
{
LabResponse labResponse = await LabUserHelper.GetArlingtonUserAsync().ConfigureAwait(false);
await AcquireTokenWithDeviceCodeFlowAsync(labResponse, "aad user").ConfigureAwait(false);
}

[TestMethod]
[Timeout(2 * 60 * 1000)] // 2 min timeout
[TestCategory(TestCategories.Arlington)]
#if IGNORE_FEDERATED
[Ignore]
#endif
public async Task ArlingtonDeviceCodeFlowAdfsTestAsync()
{
LabResponse labResponse = await LabUserHelper.GetArlingtonADFSUserAsync().ConfigureAwait(false);
await AcquireTokenWithDeviceCodeFlowAsync(labResponse, "adfs user").ConfigureAwait(false);
}

[TestMethod]
[Timeout(2 * 60 * 1000)] // 2 min timeout
[TestCategory(TestCategories.MSA)]
[Ignore("Currently failing due to environment")] //See https://github.com/AzureAD/microsoft-authentication-library-for-dotnet/issues/5264
public async Task DeviceCodeFlowMsaTestAsync()
{
LabResponse labResponse = await LabUserHelper.GetMsaUserAsync().ConfigureAwait(false);

await AcquireTokenWithDeviceCodeFlowAsync(labResponse, "msa user").ConfigureAwait(false);
}

private async Task AcquireTokenWithDeviceCodeFlowAsync(LabResponse labResponse, string userType)
{
Trace.WriteLine($"Calling AcquireTokenWithDeviceCodeAsync with {0}", userType);
Expand Down Expand Up @@ -157,61 +125,5 @@ private async Task AcquireTokenSilentAfterDeviceCodeFlowWithBrokerAsync(LabRespo
Assert.IsNotNull(silentTokenResult);
Assert.IsTrue(!string.IsNullOrEmpty(silentTokenResult.AccessToken));
}

#region Azure AD Kerberos Feature Tests
[IgnoreOnOneBranch]
[RunOn(TargetFrameworks.NetCore)]
[Timeout(2 * 60 * 1000)] // 2 min timeout
public async Task KerberosDeviceCodeFlowTestAsync()
{
LabResponse labResponse = await LabUserHelper.GetDefaultUserAsync().ConfigureAwait(false);
await KerberosAcquireTokenWithDeviceCodeFlowAsync(labResponse, "aad user", KerberosTicketContainer.IdToken).ConfigureAwait(false);
await KerberosAcquireTokenWithDeviceCodeFlowAsync(labResponse, "aad user", KerberosTicketContainer.AccessToken).ConfigureAwait(false);
}

private async Task KerberosAcquireTokenWithDeviceCodeFlowAsync(LabResponse labResponse, string userType, KerberosTicketContainer ticketContainer)
{
Trace.WriteLine($"Calling KerberosAcquireTokenWithDeviceCodeFlowAsync with {0}", userType);
var builder = PublicClientApplicationBuilder.Create(labResponse.App.AppId)
.WithTestLogging()
.WithTenantId(labResponse.Lab.TenantId)
.WithClientId(TestConstants.KerberosTestApplicationId)
.WithKerberosTicketClaim(TestConstants.KerberosServicePrincipalName, ticketContainer);

switch (labResponse.User.AzureEnvironment)
{
case AzureEnvironment.azureusgovernment:
builder.WithAuthority(labResponse.Lab.Authority + labResponse.Lab.TenantId);
break;
default:
break;
}

var pca = builder.Build();
var userCacheAccess = pca.UserTokenCache.RecordAccess();

var result = await pca.AcquireTokenWithDeviceCode(s_scopes, deviceCodeResult =>
{
SeleniumExtensions.PerformDeviceCodeLogin(deviceCodeResult, labResponse.User, TestContext, false);
return Task.FromResult(0);
}).ExecuteAsync(CancellationToken.None).ConfigureAwait(false);

Trace.WriteLine("Running asserts");

userCacheAccess.AssertAccessCounts(0, 1);
Assert.IsFalse(userCacheAccess.LastAfterAccessNotificationArgs.IsApplicationCache);

Assert.IsNotNull(result);
Assert.IsTrue(!string.IsNullOrEmpty(result.AccessToken));

KerberosSupplementalTicket ticket = TestCommon.GetValidatedKerberosTicketFromAuthenticationResult(
result,
ticketContainer,
labResponse.User.Upn);
Assert.IsNotNull(ticket);
TestCommon.ValidateKerberosWindowsTicketCacheOperation(ticket);
}

#endregion
}
}