Refactor ShadowAndroidSdkStorageEncryptionManager to use ISecretKeyProvider for key management, Fixes AB#3297746 #2326
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ovider for key management
|
❌ Work item link check failed. Description does not contain AB#{ID}. Click here to Learn more. |
|
✅ Work item link check complete. Description contains link AB#3297746 to an Azure Boards work item. |
|
❌ Work item link check failed. Description contains AB#3297746 but the Bot could not link it to an Azure Boards work item. Click here to learn more. |
github-actions
bot
changed the title
Contributor
There was a problem hiding this comment.
Pull Request Overview
Refactor the Robolectric shadow of AndroidAuthSdkStorageEncryptionManager to use the new ISecretKeyProvider interface for key handling.
- Swap out
AES256KeyLoader/PredefinedKeyLoaderforISecretKeyProvider/PredefinedKeyProvider - Rename methods and return types from
getKeyLoader*togetKeyProvider* - Update imports to match the new interfaces
Comments suppressed due to low confidence (1)
msal/src/test/java/com/microsoft/identity/client/e2e/shadows/ShadowAndroidSdkStorageEncryptionManager.java:38
- [nitpick] Consider renaming
mUserDefinedKeytomUserDefinedKeyProviderto better reflect its type (ISecretKeyProvider) and improve readability.
final ISecretKeyProvider mUserDefinedKey = new PredefinedKeyProvider("MOCK_ALIAS", encryptionKey);
...java/com/microsoft/identity/client/e2e/shadows/ShadowAndroidSdkStorageEncryptionManager.java
Outdated
Show resolved
Hide resolved
somalaya
approved these changes
Jul 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update necessary from:
AzureAD/microsoft-authentication-library-common-for-android#2666
AB#3297746