Skip to content

Conversation

@rpdome
Copy link
Member

@rpdome rpdome commented Oct 28, 2025

AB#3416279

This will allow OneAuth to wire telemetry into BrokerDiscoveryClient.getActiveBroker()

@github-actions
Copy link

❌ Work item link check failed. Description does not contain AB#{ID}.

Click here to Learn more.

@rpdome rpdome force-pushed the rapong/callback branch 2 times, most recently from 759b955 to 623021a Compare October 28, 2025 00:37
@github-actions
Copy link

github-actions bot commented Nov 4, 2025

✅ Work item link check complete. Description contains link AB#3416279 to an Azure Boards work item.

@github-actions github-actions bot changed the title wip wip, Fixes AB#3416279 Nov 4, 2025
@rpdome rpdome changed the title wip, Fixes AB#3416279 Add callback for OneAuth for measuring Broker Discovery Client Perf, Fixes AB#3416279 Nov 4, 2025
@rpdome rpdome marked this pull request as ready for review November 4, 2025 04:38
@rpdome rpdome requested review from a team as code owners November 4, 2025 04:38
Copilot AI review requested due to automatic review settings November 4, 2025 04:38
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds a new telemetry callback mechanism to the Broker Discovery Client to enable OneAuth to measure performance metrics during broker discovery operations. The changes introduce a new interface IBrokerDiscoveryClientTelemetryCallback with methods to track timing for various discovery stages, and adds an overloaded getActiveBroker method that accepts this callback as a parameter.

Key Changes

  • Added IBrokerDiscoveryClientTelemetryCallback interface defining 6 callback methods for tracking performance metrics during broker discovery
  • Extended IBrokerDiscoveryClient interface with new getActiveBroker overload accepting the telemetry callback
  • Implemented telemetry callback support in BrokerDiscoveryClient with timing measurements for cache reads, package validation, and broker queries
  • Added stub implementation in LegacyBrokerDiscoveryClient that ignores the callback (as documented)

Reviewed Changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 12 comments.

Show a summary per file
File Description
IBrokerDiscoveryClientTelemetryCallback.kt New interface defining callback methods for broker discovery performance telemetry
IBrokerDiscoveryClient.kt Added new getActiveBroker overload accepting telemetry callback parameter
BrokerDiscoveryClient.kt Implemented telemetry callback invocations with timing measurements throughout broker discovery flow
LegacyBrokerDiscoveryClient.kt Added stub implementation of new overload that ignores callback
changelog.txt Added changelog entry for this minor feature addition

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.

Copy link
Collaborator

@nickbopp nickbopp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking for a tag to measure time waiting for lock, and then we're good. Chase and I looked together so I'm signing off for both of us.

@rpdome rpdome requested a review from nickbopp November 4, 2025 23:18
@rpdome rpdome merged commit 1c95657 into dev Nov 5, 2025
24 of 25 checks passed
@rpdome rpdome deleted the rapong/callback branch November 5, 2025 23:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants