OTel Benchmarker, Fixes AB#3404902 #2786
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✅ Work item link check complete. Description contains link AB#3404902 to an Azure Boards work item. |
github-actions
bot
changed the title
rpdome
force-pushed
the
rapong/benchmark
branch
from
c3ae409 to
8b77649
Compare
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds an OpenTelemetry benchmarking system that can capture and report detailed timing statistics for telemetry spans. The benchmarker is disabled by default and provides statistical analysis (averages, percentiles) of span events with timing data.
Key changes:
- Refactored OTelUtility from Java to Kotlin with a factory pattern to support pluggable span implementations
- Added benchmarking infrastructure with configurable span factories and asynchronous data collection
- Introduced stress testing support by allowing bypass of silent token command caching
Reviewed Changes
Copilot reviewed 12 out of 12 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| OTelUtility.kt | New Kotlin implementation with factory pattern for span creation |
| OTelUtility.java | Removed original Java implementation |
| OTelBenchmarkSpanFactory.kt | Factory that creates benchmark-enabled spans for specified span names |
| IOTelSpanFactory.kt | Interface defining span factory contract |
| DefaultOTelSpanFactory.kt | Default factory implementation maintaining original behavior |
| IBenchmarkSpanPrinter.kt | Interface for asynchronous benchmark data printing |
| DefaultBenchmarkSpanPrinter.kt | Implementation that writes statistical reports to files |
| BenchmarkSpan.kt | Span wrapper that captures timing data for benchmarking |
| CommandDispatcher.java | Added method to get active thread count for concurrent request tracking |
| SilentTokenCommand.java | Added ability to bypass caching for stress testing |
| build.gradle | Added build configuration for stress test cache bypass |
| changelog.txt | Updated with new feature entry |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
common4j/src/main/com/microsoft/identity/common/java/opentelemetry/DefaultOTelSpanFactory.kt
Show resolved
Hide resolved
common4j/src/main/com/microsoft/identity/common/java/opentelemetry/DefaultOTelSpanFactory.kt
Show resolved
Hide resolved
rpdome
force-pushed
the
rapong/benchmark
branch
from
8b77649 to
ded76d0
Compare
melissaahn
reviewed
Oct 17, 2025
common4j/src/main/com/microsoft/identity/common/java/opentelemetry/OTelUtility.kt
Show resolved
Hide resolved
melissaahn
approved these changes
Oct 17, 2025
siddhijain
reviewed
Oct 24, 2025
siddhijain
approved these changes
Oct 24, 2025
rpdome
added a commit
to AzureAD/microsoft-authentication-library-for-android
that referenced
this pull request
Oct 24, 2025
[AB#3404910](https://identitydivision.visualstudio.com/fac9d424-53d2-45c0-91b5-ef6ba7a6bf26/_workitems/edit/3404910) NOTE: in order for this to work, the build config ```shouldSkipSilentTokenCommandCacheForStressTest``` must be set to true. Otherwise, the redundant requests will be absorbed by the CommandDispatcher cache and it won't be fired concurrently to broker. See AzureAD/microsoft-authentication-library-common-for-android#2786) <img width="654" height="1408" alt="image" src="https://github.com/user-attachments/assets/9603c253-a906-4ee3-afdd-f1d8767a1e35" /> --------- Co-authored-by: Copilot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AB#3404902
Add a benchmarker that can be hooked up with OTelUtility. This is disabled by default.
To Enable it, set this when the process (e.g. broker) is initiated.
This benchmarker will record the timestamp every time an attribute/event is set in the given span(s).
It would calculate (average, by percentile) and print a summary to a file that would look like this.