-
Notifications
You must be signed in to change notification settings - Fork 46
[Common] Update proguard rules, Fixes AB#3340920 #2756
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
keep base64 update rules
|
❌ Work item link check failed. Description does not contain AB#{ID}. Click here to Learn more. |
|
✅ Work item link check complete. Description contains link AB#3340920 to an Azure Boards work item. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR updates ProGuard obfuscation rules to fix build issues and improve debugging capabilities. The changes ensure that critical classes used by reflection are preserved while allowing better logging and exception handling through name preservation.
- Added
@Keepannotation toAndroidBase64class to prevent obfuscation since it's used via reflection - Updated ProGuard rules to keep names (but allow obfuscation) for Microsoft Identity classes to improve logging
- Added runtime dependency for JCIP annotations and corresponding ProGuard rules
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| AndroidBase64.kt | Added @keep annotation and documentation explaining reflection usage |
| consumer-rules.pro | Updated ProGuard rules for name preservation and annotation handling |
| build.gradle | Added JCIP annotations dependency |
| changelog.txt | Added changelog entry for the ProGuard updates |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Updated proguard rules
Fixes AB#3340920
Run: https://identitydivision.visualstudio.com/Engineering/_build/results?buildId=1532428&view=results