Native auth: JIT feature implementation #2639
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding network layer for JIT feature. Integration tests are written for the NativeAuthOAuth2Strategy class. To write tests for this class, I need to create new commandParameters classes. Since these classes are more related to the business logic, I decided to add them and the integration tests in the next PR. [AB#3188135](https://identitydivision.visualstudio.com/Engineering/_workitems/edit/3188135)
Last PR to complete JIT feature. This PR is in draft because tests are missing. You can review it in the meantime. MSAL PR: [#2290](AzureAD/microsoft-authentication-library-for-android#2290) [AB#3188136](https://identitydivision.visualstudio.com/Engineering/_workitems/edit/3188136)
nilo-ms
changed the title
Yuki-YuXin
approved these changes
May 13, 2025
spetrescu84
approved these changes
May 14, 2025
...va/com/microsoft/identity/common/nativeauth/internal/controllers/NativeAuthControllerTest.kt
Outdated
Show resolved
Hide resolved
fadidurah
reviewed
May 14, 2025
changelog.txt
Outdated
| - [MINOR] Move camera logic to CameraPermissionRequestHandler and add SdmQrPinManager (#2630) | ||
| - [MINOR] Pass Work Profile existence, OS Version, and Manufacturer to ESTS (#2627) | ||
| - [MINOR] Add telemetry for the switch browser protocol (#2612) | ||
| - [MINOR] Native auth: user can now register new strong authentication method when MFA is required (#2639) |
Contributor
There was a problem hiding this comment.
Can we include name of strong auth method in the changlog note?
Contributor
Author
There was a problem hiding this comment.
Yes, sure. Thanks Fadi
fadidurah
approved these changes
May 14, 2025
Contributor
fadidurah
left a comment
fadidurah
left a comment
There was a problem hiding this comment.
Signing off on non-nativeauth files
Yuki-YuXin
approved these changes
May 19, 2025
nilo-ms
added
the
Skip-Consumers-Check
nilo-ms
added a commit
to AzureAD/microsoft-authentication-library-for-android
that referenced
this pull request
May 20, 2025
This is the last PR that contains all the changes related to the JIT feature (registration of a new strong authentication method). MSAL Common PR: [#2639](AzureAD/microsoft-authentication-library-common-for-android#2639)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the last PR that contains all the changes related to the JIT feature (registration of a new strong authentication method).
MSAL PR: #2293