Move camera logic to CameraPermissionRequestHandler and add SdmQrPinManager , Fixes AB#3121976 #2630
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
❌ Work item link check failed. Description does not contain AB#{ID}. Click here to Learn more. |
|
✅ Work item link check complete. Description contains link AB#3121976 to an Azure Boards work item. |
github-actions
bot
changed the title
mohitc1
reviewed
Apr 28, 2025
common/src/main/java/com/microsoft/identity/common/internal/broker/SdmQrPinManager.kt
Outdated
Show resolved
Hide resolved
mohitc1
reviewed
Apr 28, 2025
...on/src/main/java/com/microsoft/identity/common/internal/broker/IBrokerRestrictionsManager.kt
Outdated
Show resolved
Hide resolved
mohitc1
reviewed
Apr 29, 2025
common/src/main/java/com/microsoft/identity/common/internal/broker/SdmQrPinManager.kt
Outdated
Show resolved
Hide resolved
mohitc1
reviewed
Apr 29, 2025
common/src/main/java/com/microsoft/identity/common/internal/broker/SdmQrPinManager.kt
Outdated
Show resolved
Hide resolved
mohitc1
reviewed
Apr 29, 2025
common/src/main/java/com/microsoft/identity/common/internal/broker/SdmQrPinManager.kt
Show resolved
Hide resolved
mohitc1
reviewed
Apr 29, 2025
...va/com/microsoft/identity/common/internal/providers/oauth2/CameraPermissionRequestHandler.kt
Outdated
Show resolved
Hide resolved
p3dr0rv
added
the
Skip-Consumers-Check
somalaya
reviewed
Apr 30, 2025
common/src/main/java/com/microsoft/identity/common/internal/broker/SdmQrPinManager.kt
Outdated
Show resolved
Hide resolved
somalaya
reviewed
Apr 30, 2025
...va/com/microsoft/identity/common/internal/providers/oauth2/CameraPermissionRequestHandler.kt
Show resolved
Hide resolved
somalaya
approved these changes
Apr 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related PR: https://github.com/AzureAD/ad-accounts-for-android/pull/3089
Run manual UI test for validation https://identitydivision.visualstudio.com/Engineering/_testPlans/execute?planId=2007357&suiteId=2810290
AB#3121976