Skip to content

Commit 1cf2577

Browse files
committed
nit corrections
1 parent 542d334 commit 1cf2577

File tree

1 file changed

+3
-4
lines changed

1 file changed

+3
-4
lines changed

common/src/main/java/com/microsoft/identity/common/internal/ui/webview/AzureActiveDirectoryWebViewClient.java

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -481,7 +481,7 @@ private boolean isWebCpAuthorizeUrl(@NonNull final String url) {
481481
}
482482

483483
final Map<String, String> queryParams = StringExtensions.getUrlParameters(url);
484-
final String clientId = queryParams.get("client_id");
484+
final String clientId = queryParams.get(AuthenticationConstants.OAuth2.CLIENT_ID);
485485

486486
if (StringUtil.isNullOrEmpty(clientId)) {
487487
Logger.info(methodTag, "Authorize URL does not contain client_id");
@@ -494,13 +494,12 @@ private boolean isWebCpAuthorizeUrl(@NonNull final String url) {
494494
: "Authorize URL contains different client_id.");
495495
return isWebCpClient;
496496

497-
} catch (URISyntaxException | MalformedURLException e) {
497+
} catch (final URISyntaxException | MalformedURLException e) {
498498
Logger.info(methodTag, "Invalid URL: " + e.getMessage());
499499
return false;
500500
}
501501
}
502502

503-
504503
private boolean isHeaderForwardingRequiredUri(@NonNull final String url) {
505504
// MSAL makes MSA requests first to login.microsoftonline.com, and then gets redirected to login.live.com.
506505
// This drops all the headers, which can have credentials useful for SSO and correlationIds useful for
@@ -811,7 +810,7 @@ private void processSSLProtectionCheck(@NonNull final WebView view,
811810
private void processInvalidUrl(@NonNull final String url) {
812811
final String methodTag = TAG + ":processInvalidUrl";
813812

814-
Logger.info(methodTag,"We are declining to override loading and redirect to invalid URL: '"
813+
Logger.infoPII(methodTag,"We are declining to override loading and redirect to invalid URL: '"
815814
+ removeQueryParametersOrRedact(url) + "' the user's url pattern is '" + mRedirectUrl + "'");
816815
}
817816

0 commit comments

Comments
 (0)