Skip to content

Commit b352bcc

Browse files
FuPingFrancoFranco Fung
andauthored
Conditionally targets NET 9 (#2561)
* Initial commit to target NET 9 * Fix ReleaseBuild.yml indentation * Fix pack step * Test fix Github action * Address feedback --------- Co-authored-by: Franco Fung <[email protected]>
1 parent b72de19 commit b352bcc

File tree

12 files changed

+38
-2
lines changed

12 files changed

+38
-2
lines changed

.github/workflows/dotnetcore.yml

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,7 @@ on:
1414
- dev
1515

1616
env:
17+
TargetNet9: True
1718
TargetNet8: True
1819

1920
jobs:
@@ -25,11 +26,21 @@ jobs:
2526
- name: Checkout repository
2627
uses: actions/[email protected]
2728

29+
- name: Setup .NET 6.0.x
30+
uses: actions/[email protected]
31+
with:
32+
dotnet-version: 6.0.x
33+
2834
- name: Setup .NET 8.0.x
2935
uses: actions/[email protected]
3036
with:
3137
dotnet-version: 8.0.x
3238

39+
- name: Setup .NET 9.0.x
40+
uses: actions/[email protected]
41+
with:
42+
dotnet-version: 9.0.100-preview.2.24157.14
43+
3344
- name: Run the tests
3445
run: dotnet test Wilson.sln
3546

benchmark/Microsoft.IdentityModel.Benchmarks/Microsoft.IdentityModel.Benchmarks.csproj

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,7 @@
55
<PackageId>Microsoft.IdentityModel.Benchmarks</PackageId>
66
<OutputType>Exe</OutputType>
77
<TargetFrameworks>net6.0;net8.0</TargetFrameworks>
8+
<TargetFrameworks Condition="'$(TargetNet9)'== 'True'">$(TargetFrameworks); net9.0</TargetFrameworks>
89
<SignAssembly>True</SignAssembly>
910
<DelaySign>True</DelaySign>
1011
<AssemblyOriginatorKeyFile>$(MSBuildThisFileDirectory)..\..\build\35MSSharedLib1024.snk</AssemblyOriginatorKeyFile>

build/commonTest.props

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@
2020
<LangVersion>12</LangVersion>
2121
</PropertyGroup>
2222

23-
<PropertyGroup Condition=" '$(TargetFramework)' == 'netcoreapp2.1' OR '$(TargetFramework)' == 'net6.0' Or '$(TargetFramework)' == 'net8.0'">
23+
<PropertyGroup Condition=" '$(TargetFramework)' == 'netcoreapp2.1' OR '$(TargetFramework)' == 'net6.0' Or '$(TargetFramework)' == 'net8.0' Or '$(TargetFramework)' == 'net9.0'">
2424
<DefineConstants>$(DefineConstants);NET_CORE</DefineConstants>
2525
</PropertyGroup>
2626

build/releaseBuild.yml

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -55,6 +55,13 @@ jobs:
5555
version: 8.x
5656
installationPath: $(Agent.ToolsDirectory)/dotnet
5757

58+
- task: UseDotNet@2
59+
displayName: 'Use .Net Core SDK 9.x'
60+
inputs:
61+
version: 9.0.100-preview.2.24157.14
62+
includePreviewVersions: true
63+
condition: eq(variables['TargetNet9'], 'True')
64+
5865
- task: DotNetCoreCLI@2
5966
displayName: 'dotnet --list-sdks'
6067
inputs:

build/targets.props

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@
22
<PropertyGroup>
33
<SrcTargets Condition="'$(LocalBuild)' != 'True'">net461;net462;net472;netstandard2.0;net6.0;net8.0</SrcTargets>
44
<SrcTargets Condition="'$(LocalBuild)' == 'True'">net461;netstandard2.0;net8.0</SrcTargets>
5+
<SrcTargets Condition="'$(TargetNet9)' == 'True'">$(SrcTargets);net9.0</SrcTargets>
56
<SrcStandardTargets>netstandard2.0</SrcStandardTargets>
67
</PropertyGroup>
78
</Project>

build/targetsTest.props

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@
22
<PropertyGroup>
33
<TestTargets Condition="'$(LocalBuild)' != 'True'">net461;net462;net472;netcoreapp2.1;net6.0;net8.0</TestTargets>
44
<TestTargets Condition="'$(LocalBuild)' == 'True'">net461;netcoreapp2.1;net8.0</TestTargets>
5+
<TestTargets Condition="'$(TargetNet9)' == 'True'">$(TestTargets);net9.0</TestTargets>
56
<TestOnlyCoreTargets>netcoreapp2.1</TestOnlyCoreTargets>
67
</PropertyGroup>
78
</Project>

src/Microsoft.IdentityModel.KeyVaultExtensions/Microsoft.IdentityModel.KeyVaultExtensions.csproj

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,7 @@
88
<GenerateDocumentationFile>true</GenerateDocumentationFile>
99
<PackageId>Microsoft.IdentityModel.KeyVaultExtensions</PackageId>
1010
<TargetFrameworks>netstandard2.0;net6.0;net8.0</TargetFrameworks>
11+
<TargetFrameworks Condition="'$(TargetNet9)' == 'True'">$(TargetFrameworks);net9.0</TargetFrameworks>
1112
<PackageTags>.NET;Windows;Authentication;Identity;Azure;Key;Vault;Extensions</PackageTags>
1213
<Nullable>enable</Nullable>
1314
</PropertyGroup>

src/Microsoft.IdentityModel.Logging/IdentityModelTelemetryUtil.cs

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -39,6 +39,8 @@ public static class IdentityModelTelemetryUtil
3939
"ID_NET6_0";
4040
#elif NET8_0
4141
"ID_NET8_0";
42+
#elif NET9_0
43+
"ID_NET9_0";
4244
#endif
4345

4446
/// <summary>

test/Microsoft.IdentityModel.AotCompatibility.TestApp/Microsoft.IdentityModel.AotCompatibility.TestApp.csproj

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@
22

33
<PropertyGroup>
44
<TargetFramework>net8.0</TargetFramework>
5+
<TargetFrameworks Condition="'$(TargetNet9)' == 'True'">$(TargetFramework); net9.0</TargetFrameworks>
56
<OutputType>Exe</OutputType>
67
<PublishTrimmed>true</PublishTrimmed>
78
<TrimMode>full</TrimMode>

test/Microsoft.IdentityModel.AotCompatibility.Tests/Microsoft.IdentityModel.AotCompatibility.Tests.csproj

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,7 @@
55
<PropertyGroup>
66
<!-- This test only needs to run on .NET -->
77
<TargetFramework>net8.0</TargetFramework>
8+
<TargetFrameworks Condition="'$(TargetNet9)'== 'True'">$(TargetFramework); net9.0</TargetFrameworks>
89
<langversion>12</langversion>
910
<Version>1.0.0-preview</Version>
1011
</PropertyGroup>

0 commit comments

Comments
 (0)