Only use fxcop in netfw

Author: Keegan Caruso

build/common.props

@@ -65,4 +65,11 @@
     <PackageReference Include="Microsoft.SourceLink.GitHub" Version="$(MicrosoftSourceLinkGitHubVersion)" PrivateAssets="All"/>
   </ItemGroup>
 
+  <ItemGroup Condition="'$(TargetFrameworkIdentifier)' != '.NETCoreApp'">
+    <PackageReference Include="Microsoft.CodeAnalysis.FxCopAnalyzers" Version="3.3.1">
+      <PrivateAssets>all</PrivateAssets>
+      <IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
+    </PackageReference>
+  </ItemGroup>
+
 </Project>

src/Microsoft.IdentityModel.Abstractions/Microsoft.IdentityModel.Abstractions.csproj

@@ -17,11 +17,4 @@
     <DebugSymbols>true</DebugSymbols>
   </PropertyGroup>
 
-  <ItemGroup>
-    <PackageReference Include="Microsoft.CodeAnalysis.FxCopAnalyzers" Version="3.0.0">
-      <PrivateAssets>all</PrivateAssets>
-      <IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
-    </PackageReference>
-  </ItemGroup>
-
 </Project>

src/Microsoft.IdentityModel.JsonWebTokens/JsonWebToken.cs

@@ -588,7 +588,7 @@ internal JsonClaimSet CreateClaimSet(ReadOnlySpan<char> strSpan, int startIndex,
         /// <returns>Encoded token string without signature or authentication tag.</returns>
         public override string ToString()
         {
-            return EncodedToken.Substring(0, EncodedToken.LastIndexOf("."));
+            return EncodedToken.Substring(0, EncodedToken.LastIndexOf('.'));
         }
 
         /// <inheritdoc/>

src/Microsoft.IdentityModel.JsonWebTokens/JsonWebTokenHandler.cs

@@ -31,7 +31,7 @@ public partial class JsonWebTokenHandler : TokenHandler
         /// <summary>
         /// Default value for the flag that determines whether or not the InboundClaimTypeMap is used.
         /// </summary>
-        public static bool DefaultMapInboundClaims = false;
+        public static bool DefaultMapInboundClaims;
 
         /// <summary>
         /// Gets the Base64Url encoded string representation of the following JWT header:

src/Microsoft.IdentityModel.JsonWebTokens/JwtTokenUtilities.cs

@@ -496,7 +496,7 @@ internal static string SafeLogJwtToken(object obj)
             if (!(obj is string token))
                 return obj.GetType().ToString();
 
-            int lastDot = token.LastIndexOf(".");
+            int lastDot = token.LastIndexOf('.');
 
             // no dots, not a JWT, we do not know how to sanitize so we return UnrecognizedEncodedToken
             if (lastDot == -1)

src/Microsoft.IdentityModel.JsonWebTokens/Microsoft.IdentityModel.JsonWebTokens.csproj

@@ -16,13 +16,6 @@
     <DebugSymbols>true</DebugSymbols>
   </PropertyGroup>
 
-  <ItemGroup>
-    <PackageReference Include="Microsoft.CodeAnalysis.FxCopAnalyzers" Version="3.0.0">
-      <PrivateAssets>all</PrivateAssets>
-      <IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
-    </PackageReference>
-  </ItemGroup>
-
   <ItemGroup>
     <ProjectReference Include="..\Microsoft.IdentityModel.Tokens\Microsoft.IdentityModel.Tokens.csproj" />
   </ItemGroup>

src/Microsoft.IdentityModel.Logging/IdentityModelEventSource.cs

@@ -33,12 +33,12 @@ private IdentityModelEventSource()
         /// <summary>
         /// Flag which indicates whether or not PII is shown in logs. False by default.
         /// </summary>
-        public static bool ShowPII { get; set; } = false;
+        public static bool ShowPII { get; set; }
 
         /// <summary>
         /// Flag which indicates whether or not complete <see cref="SecurityArtifact"/> is shown in logs when <see cref="ShowPII"/> is set to true. False by default.
         /// </summary>
-        public static bool LogCompleteSecurityArtifact { get; set; } = false;
+        public static bool LogCompleteSecurityArtifact { get; set; }
 
         /// <summary>
         /// String that is used in place of any arguments to log messages if the 'ShowPII' flag is set to false.
@@ -53,7 +53,7 @@ private IdentityModelEventSource()
         /// <summary>
         /// Indicates whether or the log message header (contains library version, date/time, and PII debugging information) has been written.
         /// </summary>
-        public static bool HeaderWritten { get; set; } = false;
+        public static bool HeaderWritten { get; set; }
 
         /// <summary>
         /// The log message that indicates the current library version.

src/Microsoft.IdentityModel.Logging/LogHelper.cs

@@ -23,7 +23,7 @@ public class LogHelper
         /// <summary>
         /// Indicates whether the log message header (contains library version, date/time, and PII debugging information) has been written.
         /// </summary>
-        private static bool _isHeaderWritten = false;
+        private static bool _isHeaderWritten;
 
         /// <summary>
         /// The log message that is shown when PII is off.

src/Microsoft.IdentityModel.Logging/LoggerContext.cs

@@ -37,7 +37,7 @@ public LoggerContext(Guid activityId)
         /// Gets or sets a boolean controlling if logs are written into the context.
         /// Useful when debugging.
         /// </summary>
-        public bool CaptureLogs { get; set; } = false;
+        public bool CaptureLogs { get; set; }
 
         /// <summary>
         /// Gets or sets a string that helps with setting breakpoints when debugging.

src/Microsoft.IdentityModel.Logging/Microsoft.IdentityModel.Logging.csproj

@@ -20,18 +20,11 @@
     <Compile Include="..\Common\TrimmingAttributes.cs" LinkBase="Common"
              Condition="'$(TargetFrameworkIdentifier)' != '.NETCoreApp'" />
   </ItemGroup>
-  
+
   <ItemGroup Condition="'$(TargetFrameworkIdentifier)' == '.NETFramework'">
     <Reference Include="System.Net.Http" />
   </ItemGroup>
 
-  <ItemGroup>
-    <PackageReference Include="Microsoft.CodeAnalysis.FxCopAnalyzers" Version="3.0.0">
-      <PrivateAssets>all</PrivateAssets>
-      <IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
-    </PackageReference>
-  </ItemGroup>
-
   <ItemGroup>
     <ProjectReference Include="..\Microsoft.IdentityModel.Abstractions\Microsoft.IdentityModel.Abstractions.csproj" />
   </ItemGroup>