Skip to content

Conversation

@japarson
Copy link
Collaborator

@japarson japarson commented May 27, 2024

This action has 3 dependencies:

  • Trusted Signing PS Module
  • Windows SDK Build Tools NuGet Package
  • Trusted Signing Client NuGet Package

We can lower execution time by caching these dependencies with GitHub's caching system. While the speedup isn't tremendous on average, it should be a massive boost in the worst-case scenario where the PowerShell Gallery decides to lag which happens quite often.

@japarson japarson marked this pull request as ready for review May 28, 2024 20:34
@japarson japarson requested a review from a team as a code owner May 28, 2024 20:34
@japarson japarson requested a review from dlemstra May 28, 2024 20:36
Copy link
Contributor

@dlemstra dlemstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for these changes! I have restarted the workflow (https://github.com/ImageMagick/ImageMagick/actions/runs/9257345710) and it is still working.

@japarson japarson merged commit 3656866 into main Jun 6, 2024
@japarson japarson deleted the dev/japarson/cache branch June 6, 2024 05:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants