Skip to content

Conversation

@msl0
Copy link

@msl0 msl0 commented Oct 9, 2025

Description

This change fixes the issue with the order of the destroy operation

Fixes #214
Closes #214

Type of Change

  • Non-module change (e.g. CI/CD, documentation, etc.)
  • Azure Verified Module updates:
    • Bugfix containing backwards compatible bug fixes
      • Someone has opened a bug report issue, and I have included "Closes #{bug_report_issue_number}" in the PR description.
      • The bug was found by the module author, and no one has opened an issue to report it yet.
    • Feature update backwards compatible feature updates.
    • Breaking changes.
    • Update to documentation

Checklist

  • I'm sure there are no other open Pull Requests for the same update/change
  • My corresponding pipelines / checks run clean and green without any errors or warnings
  • I did run all pre-commit checks

@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs: Triage 🔍 Maintainers need to triage still label Oct 9, 2025
@msl0 msl0 changed the title Pe fix fix: update keys and secrets dependencies Oct 9, 2025
@msl0
Copy link
Author

msl0 commented Oct 9, 2025

@matt-FFFFFF could you please run workflows?

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes the order of destroy operations by adding proper dependency declarations for keys and secrets modules, ensuring they depend on both managed and unmanaged DNS zone groups private endpoints. It also updates the Azure regions utility module version from 0.1.0 to 0.9.0 in the create-key example.

  • Added dependency on azurerm_private_endpoint.this_unmanaged_dns_zone_groups to both keys and secrets modules
  • Updated Azure regions utility module version to align with latest available version
  • Updated corresponding documentation to reflect the version change

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

File Description
main.secrets.tf Added dependency on unmanaged DNS zone groups private endpoint
main.keys.tf Added dependency on unmanaged DNS zone groups private endpoint
examples/create-key/main.tf Updated regions utility module version from 0.1.0 to 0.9.0
examples/create-key/README.md Updated documentation to reflect new regions utility module version

@msl0
Copy link
Author

msl0 commented Oct 11, 2025

@matt-FFFFFF thank you for approval. Is there anything else I need to do to make PR completed?

@matt-FFFFFF
Copy link
Member

closing in favour of #261 as we need a local branch for tests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Needs: Triage 🔍 Maintainers need to triage still

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[AVM Module Issue]: Destruction fails because Key Vault is no longer reachable after Private Endpoint removal

2 participants