-
Notifications
You must be signed in to change notification settings - Fork 49
fix: update keys and secrets dependencies #258
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@matt-FFFFFF could you please run workflows? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR fixes the order of destroy operations by adding proper dependency declarations for keys and secrets modules, ensuring they depend on both managed and unmanaged DNS zone groups private endpoints. It also updates the Azure regions utility module version from 0.1.0 to 0.9.0 in the create-key example.
- Added dependency on
azurerm_private_endpoint.this_unmanaged_dns_zone_groupsto both keys and secrets modules - Updated Azure regions utility module version to align with latest available version
- Updated corresponding documentation to reflect the version change
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| main.secrets.tf | Added dependency on unmanaged DNS zone groups private endpoint |
| main.keys.tf | Added dependency on unmanaged DNS zone groups private endpoint |
| examples/create-key/main.tf | Updated regions utility module version from 0.1.0 to 0.9.0 |
| examples/create-key/README.md | Updated documentation to reflect new regions utility module version |
|
@matt-FFFFFF thank you for approval. Is there anything else I need to do to make PR completed? |
|
closing in favour of #261 as we need a local branch for tests |
Description
This change fixes the issue with the order of the destroy operation
Fixes #214
Closes #214
Type of Change
Checklist