[warm/fast reboot] some service docker might have been stopped already#668
Merged
yxieca merged 4 commits intosonic-net:masterfrom Sep 25, 2019
Merged
[warm/fast reboot] some service docker might have been stopped already#668yxieca merged 4 commits intosonic-net:masterfrom
yxieca merged 4 commits intosonic-net:masterfrom
Conversation
Some services are depending on swss and might have been stopped at the time the loop of docker killing was executed. Signed-off-by: Ying Xie <ying.xie@microsoft.com>
Contributor
Author
|
retest this please |
jleveque
reviewed
Sep 24, 2019
pavel-shirshov
approved these changes
Sep 24, 2019
qiluo-msft
reviewed
Sep 24, 2019
jleveque
reviewed
Sep 25, 2019
jleveque
approved these changes
Sep 25, 2019
qiluo-msft
approved these changes
Sep 25, 2019
Contributor
Author
|
retest this please |
yxieca
added a commit
that referenced
this pull request
Sep 25, 2019
#668) * [warm/fast reboot] some service docker might have been stopped already Some services are depending on swss and might have been stopped at the time the loop of docker killing was executed. Signed-off-by: Ying Xie <ying.xie@microsoft.com> * log and ignore all errors while killing containers * add debug message * put redirect at the right place
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
- What I did
Some services are depending on swss and might have been stopped at the
time the loop of docker killing was executed.
Signed-off-by: Ying Xie ying.xie@microsoft.com
- How to verify it
Without the change, continuous fast-reboot seems to hit the issue fairly frequently where snmp docker has been stopped when reaching the docker kill loop. And that would cause test to fail.
With the fix, the snmp docker could still be killed already, but test would continue.