Add LDAP feature CLI support#3022
Conversation
davidpil2002
force-pushed
the
dev-add-ldap-support
branch
2 times, most recently
from
bdd2580 to
475e92a
Compare
davidpil2002
force-pushed
the
dev-add-ldap-support
branch
from
1bcc751 to
bb5f4d3
Compare
|
@lguohan who should review and provide feedback? |
| show_ldap_global="""\ | ||
| BIND DN BIND PASSWORD BIND TIMEOUT VERSION BASE DN PORT TIMEOUT | ||
| ---------------------------- --------------- -------------- --------- ----------------- ------ --------- | ||
| cn=ldapadm,dc=test1,dc=test2 password 3 3 dc=test1,dc=test2 389 2 |
There was a problem hiding this comment.
what are the units for BIND TIMEOUT and LDAP TIMEOUT?
There was a problem hiding this comment.
Is it possible to mention in the header (secs)?
| validate_config_or_raise(cfg) | ||
| db.set_entry(table, key, None) | ||
|
|
||
|
|
There was a problem hiding this comment.
It is auto generated code, code cleanup must be done.
| body.append(row) | ||
|
|
||
| click.echo(tabulate.tabulate(body, header)) | ||
|
|
There was a problem hiding this comment.
Auto generated code, refactor and code clean up must be done
There was a problem hiding this comment.
The code was autogenerated by using sonic-cli-gen tool
fixed spaces as you mentioned,
pls comment if there is some other issue.
thanks
davidpil2002
force-pushed
the
dev-add-ldap-support
branch
3 times, most recently
from
2dcee1f to
ede8825
Compare
|
@madhupalu , please approve if everything looks good |
davidpil2002
force-pushed
the
dev-add-ldap-support
branch
2 times, most recently
from
cc99892 to
f80960d
Compare
davidpil2002
force-pushed
the
dev-add-ldap-support
branch
from
f80960d to
e7b795c
Compare
davidpil2002
force-pushed
the
dev-add-ldap-support
branch
from
aea3d0e to
5a27799
Compare
|
@madhupalu Do you have more comments? |
There was a problem hiding this comment.
In order to merge it @davidpil2002 @Yarden-Z please check command reference guide and update it with the new additional CLIs. https://github.com/sonic-net/sonic-utilities/blob/master/doc/Command-Reference.md#lldp
liat-grozovik
left a comment
liat-grozovik
left a comment
There was a problem hiding this comment.
need to update command reference guide
davidpil2002
force-pushed
the
dev-add-ldap-support
branch
from
5a27799 to
3069f8b
Compare
rebase and update Command-Reference.md file |
davidpil2002
force-pushed
the
dev-add-ldap-support
branch
6 times, most recently
from
b1efed5 to
9da844f
Compare
davidpil2002
force-pushed
the
dev-add-ldap-support
branch
from
9da844f to
5d09fdd
Compare
davidpil2002
force-pushed
the
dev-add-ldap-support
branch
from
5d09fdd to
9435879
Compare
- What I did Add LDAP CLI - How I did it created the CLI by using YANG model generator, the YANG model can be found in the LDAP HLD: sonic-net/SONiC#1487 - How to verify it Manually: you can use configurations command like"config ldap global " or "show ldap global" (more examples in the HLD.) Auto: 1.There are unitest of each policy including good & bad flow in this commit, that should pass.
- What I did Add LDAP CLI - How I did it created the CLI by using YANG model generator, the YANG model can be found in the LDAP HLD: sonic-net/SONiC#1487 - How to verify it Manually: you can use configurations command like"config ldap global " or "show ldap global" (more examples in the HLD.) Auto: 1.There are unitest of each policy including good & bad flow in this commit, that should pass.
6 participants
What I did
Add LDAP CLI
How I did it
created the CLI by using YANG model generator, the YANG model can be found in the LDAP HLD:
sonic-net/SONiC#1487
How to verify it
Manually:
you can use configurations command like"config ldap global " or
"show ldap global" (more examples in the HLD.)
Auto:
1.There are unitest of each policy including good & bad flow in this commit, that should pass.
Previous command output (if the output of a command-line utility has changed)
No prev commands - New feature
New command output (if the output of a command-line utility has changed)