[GCU] Supporting Groupings during path-xpath translation#2044
Merged
ghooo merged 3 commits intosonic-net:masterfrom Feb 23, 2022
Merged
[GCU] Supporting Groupings during path-xpath translation#2044ghooo merged 3 commits intosonic-net:masterfrom
ghooo merged 3 commits intosonic-net:masterfrom
Conversation
ghooo
force-pushed
the
dev/mghoneim/groupings
branch
7 times, most recently
from
65a7dde to
d71596c
Compare
qiluo-msft
reviewed
Jan 27, 2022
qiluo-msft
reviewed
Jan 27, 2022
qiluo-msft
reviewed
Jan 27, 2022
qiluo-msft
reviewed
Jan 27, 2022
tests/generic_config_updater/files/config_db_with_bgp_neighbor.json
Outdated
Show resolved
Hide resolved
ghooo
commented
Jan 28, 2022
wen587
previously approved these changes
Jan 28, 2022
Contributor
wen587
left a comment
wen587
left a comment
There was a problem hiding this comment.
Test locally and BGP_MONITOR tests works fine.
Contributor
Author
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
ghooo
force-pushed
the
dev/mghoneim/groupings
branch
from
0019777 to
2bb1c02
Compare
4 tasks
ghooo
force-pushed
the
dev/mghoneim/groupings
branch
from
2bb1c02 to
21b748e
Compare
qiluo-msft
previously approved these changes
Feb 17, 2022
qiluo-msft
approved these changes
Feb 19, 2022
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I did
Fixes #2041
Supporting groupings during
config-db path<->config-yang xpathtranslationThis mimics the
config-db<->config-yangtranslation as added by sonic-net/sonic-buildimage#8318How I did it
Handled groupings of leaf commands only as that's what is supported in sonic-yang-mgmt
How to verify it
unit-test
Previous command output (if the output of a command-line utility has changed)
New command output (if the output of a command-line utility has changed)