[generic_config_updater] Minor update - No logical code change#2028
Merged
renukamanavalan merged 29 commits intosonic-net:masterfrom Jan 20, 2022
Merged
[generic_config_updater] Minor update - No logical code change#2028renukamanavalan merged 29 commits intosonic-net:masterfrom
renukamanavalan merged 29 commits intosonic-net:masterfrom
Conversation
2) Read conf file from install dir 3) Drop empty keys & tables upon jsonpatch.JsonPatch.apply to be in sync with redis update 4) Prefix service_validator module path with "generic_updater"
2) Added vlan validator 3) Added test code for vlan validator
No logical code change.
renukamanavalan
changed the title
qiluo-msft
approved these changes
Jan 20, 2022
judyjoseph
pushed a commit
that referenced
this pull request
Jan 31, 2022
What I did Missed update from review comments in PR #2020 s/os.system("sleep 10s")/time.sleep(10)/
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I did
Missed update from review comments in PR #2020
s/os.system("sleep 10s")/time.sleep(10)/
How I did it
How to verify it
Previous command output (if the output of a command-line utility has changed)
New command output (if the output of a command-line utility has changed)