[debug dump util] Portchannel module added#1853
Merged
SuvarnaMeenakshi merged 8 commits intosonic-net:masterfrom Nov 10, 2021
Merged
[debug dump util] Portchannel module added#1853SuvarnaMeenakshi merged 8 commits intosonic-net:masterfrom
SuvarnaMeenakshi merged 8 commits intosonic-net:masterfrom
Conversation
Signed-off-by: Vivek Reddy Karri <[email protected]>
Signed-off-by: Vivek Reddy Karri <[email protected]>
Signed-off-by: Vivek Reddy Karri <[email protected]>
Signed-off-by: Vivek Reddy Karri <[email protected]>
|
This pull request introduces 1 alert when merging 179a092 into 5bdf270 - view on LGTM.com new alerts:
|
Collaborator
|
@SuvarnaMeenakshi Can you please review? |
Collaborator
|
@SuvarnaMeenakshi could you please help review? |
dgsudharsan
approved these changes
Nov 10, 2021
Contributor
Author
|
@SuvarnaMeenakshi, That should be possible, I'll raise a separate PR covering all the modules at once. That'll be a cleaner way. What do you think? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I did
Note: Portchannel member accepts the keys of PORTCHANNEL_MEMBER table as the Identifier and since the key contains this character ("|"), this should be escaped using single quotes while using the utility i.e.
dump state portchannel_member 'PortChannel001|Ethernet4,PortChannel001|Ethernet8'How I did it
How to verify it
Previous command output (if the output of a command-line utility has changed)
New command output (if the output of a command-line utility has changed)