VxLAN Tunnel Counters and Rates implementation by dgsudharsan · Pull Request #1748 · sonic-net/sonic-utilities

dgsudharsan · 2021-08-07T05:00:10Z

What I did

Implemented Vxlan counters and rates. Defined show commands for counters and rates similar to port and tunnel rates.

How I did it

Implemented tunnelstat utility and used it in show vxlan counters command.

How to verify it

Using unit tests in CLI

Previous command output (if the output of a command-line utility has changed)

New command output (if the output of a command-line utility has changed)

show vxlan counters
    IFACE    RX_PKTS    RX_BYTES    RX_PPS    TX_PKTS    TX_BYTES    TX_PPS
---------  ---------  ----------  --------  ---------  ----------  --------
vtep_1336      2,359         N/A    0.99/s    205,972         N/A   86.93/s

show vxlan counters  vtep_1336
vtep_1336
---------

        RX:
                13 packets
               N/A bytes
        TX:
             1,164 packets
               N/A bytes

lgtm-com · 2021-08-07T05:10:45Z

This pull request introduces 4 alerts when merging 19fff55 into 30907c4 - view on LGTM.com

new alerts:

2 for Unused import
1 for Variable defined multiple times
1 for Clear-text logging of sensitive information

lgtm-com · 2021-08-07T18:41:12Z

This pull request introduces 1 alert when merging 7a12c0f0cfb62d20d1aa94f7dd19fc3fdaa1b5c8 into 30907c4 - view on LGTM.com

new alerts:

1 for Unused import

dgsudharsan · 2021-08-07T18:42:28Z

This pull request introduces 1 alert when merging 7a12c0f into 30907c4 - view on LGTM.com

new alerts:

1 for Unused import

This lgtm is for using mock table dbconnector and its by the existing design. We should ignore this lgtm.

lgtm-com · 2021-10-16T03:47:32Z

This pull request introduces 3 alerts when merging d5f82f3e6a34f06e506ad049a62629acca46500c into d8ee5e9 - view on LGTM.com

new alerts:

2 for Variable defined multiple times
1 for Unused import

lgtm-com · 2021-10-16T04:52:23Z

This pull request introduces 1 alert when merging 2f93cb11d267ffceb27a7b9a2d516599f90dad5d into d8ee5e9 - view on LGTM.com

new alerts:

1 for Unused import

lgtm-com · 2021-10-16T05:11:55Z

This pull request introduces 1 alert when merging c97e1597b609a27c683fe00f40a28e86546cd37a into d8ee5e9 - view on LGTM.com

new alerts:

1 for Unused import

lgtm-com · 2021-10-21T05:04:42Z

This pull request introduces 1 alert when merging 165546bce5a0180a24c86dc9977d46561bd486e5 into 9017d99 - view on LGTM.com

new alerts:

1 for Unused import

lgtm-com · 2021-10-22T03:50:41Z

This pull request introduces 2 alerts when merging 91c96c4 into 9017d99 - view on LGTM.com

new alerts:

2 for Unused import

srj102 · 2021-10-22T04:14:42Z

scripts/tunnelstat

+nstat_fields = ("rx_b_ok", "rx_p_ok", "tx_b_ok", "tx_p_ok")
+NStats = namedtuple("NStats", nstat_fields)
+
+header = ['IFACE', 'RX_OK', 'RX_BYTES', 'RX_PPS','TX_OK', 'TX_BYTES', 'TX_PPS']


would it be better to change TX_OK to TX_PKT as we are using bytes for the other column ? Same for RX_OK and RX_PKT

lgtm-com · 2021-10-22T05:30:24Z

This pull request introduces 2 alerts when merging 5d0c058 into 9017d99 - view on LGTM.com

new alerts:

2 for Unused import

lgtm-com · 2021-10-22T05:42:56Z

This pull request introduces 1 alert when merging fe622b2 into 9017d99 - view on LGTM.com

new alerts:

1 for Unused import

dgsudharsan · 2021-10-22T16:22:51Z

/azpw run

mssonicbld · 2021-10-22T16:22:54Z

/AzurePipelines run

azure-pipelines · 2021-10-22T16:23:04Z

Azure Pipelines successfully started running 1 pipeline(s).

lgtm-com · 2021-10-22T17:00:16Z

This pull request introduces 1 alert when merging 81df07d into 9017d99 - view on LGTM.com

new alerts:

1 for Unused import

dgsudharsan · 2021-10-23T03:21:04Z

/azpw run

mssonicbld · 2021-10-23T03:21:05Z

/AzurePipelines run

azure-pipelines · 2021-10-23T03:21:16Z

Azure Pipelines successfully started running 1 pipeline(s).

dgsudharsan · 2021-10-25T02:06:40Z

/azpw run

mssonicbld · 2021-10-25T02:06:41Z

/AzurePipelines run

azure-pipelines · 2021-10-25T02:06:52Z

Azure Pipelines successfully started running 1 pipeline(s).

dgsudharsan · 2021-10-25T05:05:12Z

/azpw run

mssonicbld · 2021-10-25T05:05:13Z

/AzurePipelines run

azure-pipelines · 2021-10-25T05:05:27Z

Azure Pipelines successfully started running 1 pipeline(s).

…lan_tun_cntrs

lgtm-com · 2021-10-25T14:08:14Z

This pull request introduces 1 alert when merging 45d9a47 into 8ea834b - view on LGTM.com

new alerts:

1 for Unused import

dgsudharsan · 2021-10-25T22:01:54Z

/azpw run

mssonicbld · 2021-10-25T22:01:56Z

/AzurePipelines run

azure-pipelines · 2021-10-25T22:02:11Z

Azure Pipelines successfully started running 1 pipeline(s).

dgsudharsan · 2021-10-26T14:34:56Z

/azpw run

mssonicbld · 2021-10-26T14:34:58Z

/AzurePipelines run

azure-pipelines · 2021-10-26T14:35:12Z

Azure Pipelines successfully started running 1 pipeline(s).

prsunny · 2021-10-29T22:11:02Z

scripts/tunnelstat

@@ -0,0 +1,342 @@
+#!/usr/bin/env python3


Please update the CLI command reference guide.

* Vxlan Tunnel counters implementation

* VxLAN Tunnel Counters and Rates implementation (#1748)

dgsudharsan mentioned this pull request Aug 9, 2021

EVPN VxLAN update for platforms using P2MP tunnel based L2 forwarding sonic-net/SONiC#806

Merged

dgsudharsan added 10 commits October 21, 2021 04:56

Tunnel counters implementation

a276655

Calculate rates from lua

d9c9fca

Added UT for tunnel stats

dc934ca

Addressing code review comments

3a86437

Fixing lgtm

4df3a51

Fixing build failure

4162427

Updating setup.py

44dc509

Removing unused variables

5fdbffc

Removing duplicate code

5fa80f2

Fixing UT

c2bb8ed

Changing bytes/sec to bytes since its more appropriate for tunnel stats

91c96c4

dgsudharsan force-pushed the evpn_vlan_tun_cntrs branch from 165546b to 91c96c4 Compare October 22, 2021 03:40

srj102 reviewed Oct 22, 2021

View reviewed changes

Addressing code review comments

5d0c058

srj102 previously approved these changes Oct 22, 2021

View reviewed changes

Fixing lgtm

fe622b2

dgsudharsan dismissed srj102’s stale review via fe622b2 October 22, 2021 05:32

dgsudharsan added 2 commits October 22, 2021 16:47

Cosmetic changes

61d85fb

Cosmetic changes

81df07d

Merge branch 'master' of github.com:Azure/sonic-utilities into evpn_v…

45d9a47

…lan_tun_cntrs

prsunny approved these changes Oct 29, 2021

View reviewed changes

scripts/tunnelstat

@@ -0,0 +1,342 @@

#!/usr/bin/env python3

Copy link

Contributor

prsunny Oct 29, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update the CLI command reference guide.

prsunny merged commit 0665d6f into sonic-net:master Oct 29, 2021

dgsudharsan added a commit to dgsudharsan/sonic-utilities that referenced this pull request Jun 30, 2022

VxLAN Tunnel Counters and Rates implementation (sonic-net#1748)

8de6e92

* Vxlan Tunnel counters implementation

dgsudharsan added a commit to dgsudharsan/sonic-utilities that referenced this pull request Aug 26, 2022

VxLAN Tunnel Counters and Rates implementation (sonic-net#1748)

e020b0a

* Vxlan Tunnel counters implementation

dgsudharsan mentioned this pull request Sep 6, 2022

[202012][VxLAN]VxLAN Tunnel Counters and Rates implementation #2353

Merged

prsunny pushed a commit that referenced this pull request Sep 9, 2022

[202012][VxLAN]VxLAN Tunnel Counters and Rates implementation (#2353)

2604390

* VxLAN Tunnel Counters and Rates implementation (#1748)

dgsudharsan deleted the evpn_vlan_tun_cntrs branch March 9, 2023 02:06

Conversation

dgsudharsan commented Aug 7, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What I did

How I did it

How to verify it

Previous command output (if the output of a command-line utility has changed)

New command output (if the output of a command-line utility has changed)

Uh oh!

lgtm-com bot commented Aug 7, 2021

Uh oh!

lgtm-com bot commented Aug 7, 2021

Uh oh!

dgsudharsan commented Aug 7, 2021

Uh oh!

lgtm-com bot commented Oct 16, 2021

Uh oh!

lgtm-com bot commented Oct 16, 2021

Uh oh!

lgtm-com bot commented Oct 16, 2021

Uh oh!

lgtm-com bot commented Oct 21, 2021

Uh oh!

lgtm-com bot commented Oct 22, 2021

Uh oh!

srj102 Oct 22, 2021

Choose a reason for hiding this comment

Uh oh!

dgsudharsan Oct 22, 2021

Choose a reason for hiding this comment

Uh oh!

lgtm-com bot commented Oct 22, 2021

Uh oh!

lgtm-com bot commented Oct 22, 2021

Uh oh!

dgsudharsan commented Oct 22, 2021

Uh oh!

mssonicbld commented Oct 22, 2021

Uh oh!

azure-pipelines bot commented Oct 22, 2021

Uh oh!

lgtm-com bot commented Oct 22, 2021

Uh oh!

dgsudharsan commented Oct 23, 2021

Uh oh!

mssonicbld commented Oct 23, 2021

Uh oh!

azure-pipelines bot commented Oct 23, 2021

Uh oh!

dgsudharsan commented Oct 25, 2021

Uh oh!

mssonicbld commented Oct 25, 2021

Uh oh!

azure-pipelines bot commented Oct 25, 2021

Uh oh!

dgsudharsan commented Oct 25, 2021

Uh oh!

mssonicbld commented Oct 25, 2021

Uh oh!

azure-pipelines bot commented Oct 25, 2021

Uh oh!

lgtm-com bot commented Oct 25, 2021

Uh oh!

dgsudharsan commented Oct 25, 2021

Uh oh!

mssonicbld commented Oct 25, 2021

Uh oh!

azure-pipelines bot commented Oct 25, 2021

Uh oh!

dgsudharsan commented Oct 26, 2021

Uh oh!

mssonicbld commented Oct 26, 2021

Uh oh!

azure-pipelines bot commented Oct 26, 2021

Uh oh!

prsunny Oct 29, 2021

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

dgsudharsan commented Aug 7, 2021 •

edited

Loading