[pbh] [aclorch] Fixed a bug causes by updating the flow-counter value for the PBH rule by vadymhlushko-mlnx · Pull Request #2226 · sonic-net/sonic-swss

vadymhlushko-mlnx · 2022-04-08T13:34:13Z

What I did
Added the register and deregister functions for the flex counter before updating counters for the ACL rule.

Why I did it
Overcome SAI error in case of flow counters disabled and then enabled.

For example:

Show PBH rules:

root@sonic:/home/admin# show pbh rule
TABLE      RULE             PRIORITY    MATCH                                 HASH        ACTION         COUNTER
---------  ---------------  ----------  ------------------------------------  ----------  -------------  ---------
pbh_table  nvgre_ipv4_ipv4  2           gre_key:           0x2500/0xffffff00  inner_hash  SET_ECMP_HASH  ENABLED
                                        ether_type:        0x0800
                                        ip_protocol:       0x2f
                                        inner_ether_type:  0x0800

Update PBH rule:

root@sonic:/home/admin# config pbh rule update field set pbh_table nvgre_ipv4_ipv4  --flow-counter DISABLED
root@sonic:/home/admin# config pbh rule update field set pbh_table nvgre_ipv4_ipv4  --flow-counter ENABLED

Observed behavior:

NOTICE syncd#SDK: [SAI_UTILS.NOTICE] mlnx_sai_utils.c[1833]- set_dispatch_attrib_handler: Set ACTION_COUNTER, key:ACL Entry [1], val:NULL,(0:0),0,0000,0
NOTICE syncd#SDK: [SAI_ACL.NOTICE] mlnx_sai_acl.c[14326]- mlnx_delete_acl_counter: Delete ACL Counter ACL Counter [311296] type (byte:true, packet:true)
NOTICE swss#orchagent: :- updateRule: Successfully updated ACL rule nvgre_ipv4_ipv4 in table pbh_table
NOTICE swss#orchagent: :- updatePbhRule: Updated PBH rule(pbh_table|nvgre_ipv4_ipv4) in SAI
ERR syncd#SDK: [GBIN_ALLOCATOR.ERR] LID 38 doesn't exist!
ERR syncd#SDK: [FLOW_COUNTER.ERR] spectrum_flow_counter_lock: cm_lock failed [lid=38, flow_counter_id=311296]
ERR syncd#SDK: [FLOW_COUNTER.ERR] spectrum_flow_counter_get: spectrum_flow_counter_lock failed [cntr_id=311296]
ERR syncd#SDK: [SAI_ACL.ERR] mlnx_sai_acl.c[13776]- mlnx_acl_counter_get:  Failure to get counter in SDK - Entry Not Found
ERR syncd#SDK: [SAI_UTILS.ERR] mlnx_sai_utils.c[1931]- get_dispatch_attribs_handler: Failed getting attrib SAI_ACL_COUNTER_ATTR_BYTES
ERR syncd#SDK: [SAI_UTILS.ERR] mlnx_sai_utils.c[2068]- sai_get_attributes: Failed attribs dispatch
WARNING syncd#SDK: :- collectAclCounterAttrs: Failed to get attr of ACL counter oid:0x9000000001680: SAI_STATUS_ITEM_NOT_FOUND
ERR syncd#SDK: [GBIN_ALLOCATOR.ERR] LID 38 doesn't exist!

How I verified it
Added a UT.

Details if related

prsunny · 2022-04-09T01:44:57Z

@anish-n , please review

prsunny · 2022-04-09T01:45:04Z

/azp run

azure-pipelines · 2022-04-09T01:45:14Z

Azure Pipelines successfully started running 1 pipeline(s).

liat-grozovik · 2022-04-11T12:46:41Z

/azp run Azure.sonic-swss

azure-pipelines · 2022-04-11T12:46:52Z

Azure Pipelines successfully started running 1 pipeline(s).

vadymhlushko-mlnx · 2022-04-12T15:56:55Z

/azpw run coverage.Azure.sonic-swss.amd64

mssonicbld · 2022-04-12T15:56:56Z

/AzurePipelines run coverage.Azure.sonic-swss.amd64

azure-pipelines · 2022-04-12T15:57:02Z

No pipelines are associated with this pull request.

vadymhlushko-mlnx · 2022-04-12T15:57:23Z

/azpw run coverage.Azure.sonic-swss

mssonicbld · 2022-04-12T15:57:24Z

/AzurePipelines run coverage.Azure.sonic-swss

azure-pipelines · 2022-04-12T15:57:29Z

No pipelines are associated with this pull request.

vadymhlushko-mlnx · 2022-04-12T15:57:44Z

/azpw run Azure.sonic-swss

mssonicbld · 2022-04-12T15:57:45Z

/AzurePipelines run Azure.sonic-swss

azure-pipelines · 2022-04-12T15:57:55Z

Azure Pipelines successfully started running 1 pipeline(s).

… counter before updating counter for ACL rule Signed-off-by: Vadym Hlushko <vadymh@nvidia.com>

Signed-off-by: Vadym Hlushko <vadymh@nvidia.com>

…eview comments Signed-off-by: Vadym Hlushko <vadymh@nvidia.com>

Signed-off-by: Vadym Hlushko <vadymh@nvidia.com>

vadymhlushko-mlnx · 2022-04-18T16:48:20Z

/azpw run Azure.sonic-swss

mssonicbld · 2022-04-18T16:48:21Z

/AzurePipelines run Azure.sonic-swss

azure-pipelines · 2022-04-18T16:48:31Z

Azure Pipelines successfully started running 1 pipeline(s).

liat-grozovik · 2022-04-22T08:17:33Z

@anish-n kindly reminder to review this PR

… for the PBH rule (#2226) - What I did Added the register and deregister functions for the flex counter before updating counters for the ACL rule. - Why I did it Overcome SAI error in case of flow counters disabled and then enabled. - How I verified it Added a UT. Signed-off-by: Vadym Hlushko <vadymh@nvidia.com>

… for the PBH rule (sonic-net#2226) - What I did Added the register and deregister functions for the flex counter before updating counters for the ACL rule. - Why I did it Overcome SAI error in case of flow counters disabled and then enabled. - How I verified it Added a UT. Signed-off-by: Vadym Hlushko <vadymh@nvidia.com>

vadymhlushko-mlnx requested a review from prsunny as a code owner April 8, 2022 13:34

nazariig previously approved these changes Apr 8, 2022

View reviewed changes

stepanblyschak previously approved these changes Apr 8, 2022

View reviewed changes

vadymhlushko-mlnx dismissed stale reviews from stepanblyschak and nazariig via 9822e6e April 12, 2022 17:08

dprital added the Request for 202111 Branch label Apr 13, 2022

vadymhlushko-mlnx added 5 commits April 13, 2022 14:21

[pbh] [aclorch] Addded the register and deregister functions for flex…

332ad03

… counter before updating counter for ACL rule Signed-off-by: Vadym Hlushko <vadymh@nvidia.com>

[pbh] [aclorch] Added UT

ee106ba

Signed-off-by: Vadym Hlushko <vadymh@nvidia.com>

[pbh] [aclorch] Fixed deletion flow for ACL_COUNTER_RULE_MAP, fixed r…

f0e5040

…eview comments Signed-off-by: Vadym Hlushko <vadymh@nvidia.com>

Fixed review comments

af190f2

Signed-off-by: Vadym Hlushko <vadymh@nvidia.com>

Removed time

468cfb6

Signed-off-by: Vadym Hlushko <vadymh@nvidia.com>

vadymhlushko-mlnx force-pushed the pbh_edit_flows_acl_fix branch 2 times, most recently from 53a3cbd to 468cfb6 Compare April 18, 2022 08:08

stepanblyschak approved these changes Apr 19, 2022

View reviewed changes

nazariig approved these changes Apr 19, 2022

View reviewed changes

liat-grozovik approved these changes Apr 19, 2022

View reviewed changes

anish-n approved these changes Apr 22, 2022

View reviewed changes

liat-grozovik merged commit 841f003 into sonic-net:master Apr 23, 2022

judyjoseph added the Included in 202111 Branch label Apr 25, 2022

sumukhatv mentioned this pull request Apr 30, 2022

[SWSS] Update submodule sonic-net/sonic-buildimage#10719

Merged

5 tasks

Conversation

vadymhlushko-mlnx commented Apr 8, 2022 • edited by liat-grozovik Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

prsunny commented Apr 9, 2022

Uh oh!

prsunny commented Apr 9, 2022

Uh oh!

azure-pipelines bot commented Apr 9, 2022

Uh oh!

liat-grozovik commented Apr 11, 2022

Uh oh!

azure-pipelines bot commented Apr 11, 2022

Uh oh!

vadymhlushko-mlnx commented Apr 12, 2022

Uh oh!

mssonicbld commented Apr 12, 2022

Uh oh!

azure-pipelines bot commented Apr 12, 2022

Uh oh!

vadymhlushko-mlnx commented Apr 12, 2022

Uh oh!

mssonicbld commented Apr 12, 2022

Uh oh!

azure-pipelines bot commented Apr 12, 2022

Uh oh!

vadymhlushko-mlnx commented Apr 12, 2022

Uh oh!

mssonicbld commented Apr 12, 2022

Uh oh!

azure-pipelines bot commented Apr 12, 2022

Uh oh!

vadymhlushko-mlnx commented Apr 18, 2022

Uh oh!

mssonicbld commented Apr 18, 2022

Uh oh!

azure-pipelines bot commented Apr 18, 2022

Uh oh!

liat-grozovik commented Apr 22, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

vadymhlushko-mlnx commented Apr 8, 2022 •

edited by liat-grozovik

Loading