[VNET]Fixing nexthop group delete during route change#2198
Merged
prsunny merged 2 commits intosonic-net:masterfrom Mar 29, 2022
Merged
[VNET]Fixing nexthop group delete during route change#2198prsunny merged 2 commits intosonic-net:masterfrom
prsunny merged 2 commits intosonic-net:masterfrom
Conversation
prsunny
approved these changes
Mar 24, 2022
Collaborator
Author
|
/azpw run Azure.sonic-swss (BuildArm arm64) |
Collaborator
|
/AzurePipelines run Azure.sonic-swss (BuildArm arm64) |
|
No pipelines are associated with this pull request. |
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
|
/azp run Azure.sonic-swss |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
Author
|
/azpw run Azure.sonic-swss |
Collaborator
|
/AzurePipelines run Azure.sonic-swss |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
Author
|
/azpw run Azure.sonic-swss |
Collaborator
|
/AzurePipelines run Azure.sonic-swss |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
Author
|
/azpw run Azure.sonic-swss |
Collaborator
|
/AzurePipelines run Azure.sonic-swss |
|
Azure Pipelines successfully started running 1 pipeline(s). |
qiluo-msft
pushed a commit
that referenced
this pull request
Mar 29, 2022
*[Overlay ECMP] Fix for VNET with nexthop group is replaced with a single nexthop
judyjoseph
pushed a commit
that referenced
this pull request
Apr 4, 2022
*[Overlay ECMP] Fix for VNET with nexthop group is replaced with a single nexthop
preetham-singh
pushed a commit
to preetham-singh/sonic-swss
that referenced
this pull request
Aug 6, 2022
*[Overlay ECMP] Fix for VNET with nexthop group is replaced with a single nexthop
Janetxxx
pushed a commit
to Janetxxx/sonic-swss
that referenced
this pull request
Nov 10, 2025
*[Overlay ECMP] Fix for VNET with nexthop group is replaced with a single nexthop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I did
When a VNET with nexthop group is replaced with a single nexthop the following error is seen in the test
Mar 23 14:08:30.801303 r-leopard-01 ERR swss#orchagent: :- doTask: Parse error: Error converting 100.0.5.1@@0@00:00:00:00:00:00,100.0.6.1@@0@00:00:00:00:00:00 to NextHop
Why I did it
The issue is due to the reason that in the removing existing nexthop flow, instead of looking at size of existing nexthop to determine if it is a group or single NH, the new nexthop is considered which leads to incorrect classification in the above scenario.
Modified the code to consider the existing nhg instead of new ones.
How I verified it
Verified the case by testing the above scenario.
Details if related