Remove buffer drop counter when port is deleted by tomer-israel · Pull Request #1860 · sonic-net/sonic-swss

tomer-israel · 2021-08-09T10:58:05Z

What I did
I added the removal of port buffer drop counter on the deinit port flow.
it was added to the deInitPort function.

Why I did it
the buffer drop counter was never removed when port was deleted.
this flex counter was create on the initPort function but it was removed when the port was deleted

How I verified it
removed and created a port and check the FLEX_COUNTER redis table

FLEX_COUNTER_TABLE:PORT_BUFFER_DROP_STAT table

Details if related

tomer-israel · 2021-08-09T15:08:17Z

/azpw run

tomer-israel · 2021-08-09T21:27:18Z

/azp run

azure-pipelines · 2021-08-09T21:27:23Z

Commenter does not have sufficient privileges for PR 1860 in repo Azure/sonic-swss

tomer-israel · 2021-08-11T10:40:59Z

i have these failures on the swss checkers:

test_zero_cable_len_profile_update
test_route_nhg
test_route_nhg_exhaust
test_SpeedAndBufferSet

vs tests:
test_SpeedAndBufferSet failed (1 runs remaining out of 2).
<class 'AssertionError'>
Unexpected number of keys: expected=4, received=3 (('egress_lossy_profile', 'egress_lossless_profile', 'ingress_lossy_profile')), table="BUFFER_PROFILE"
[<TracebackEntry /home/vsts/work/1/s/tests/test_speed.py:39>, <TracebackEntry /home/vsts/work/1/s/tests/dvslib/dvs_database.py:366>]
test_SpeedAndBufferSet failed; it passed 0 out of the required 1 times.
<class 'AssertionError'>
Unexpected number of keys: expected=4, received=3 (('egress_lossy_profile', 'egress_lossless_profile', 'ingress_lossy_profile')), table="BUFFER_PROFILE"
[<TracebackEntry /home/vsts/work/1/s/tests/test_speed.py:39>, <TracebackEntry /home/vsts/work/1/s/tests/dvslib/dvs_database.py:366>]

it looks not related to my change and I also saw the same errors on this PR (the PR is not related to our PR):
#1861

so maybe we need to rerun these tests
@prsunny

liat-grozovik · 2021-08-16T09:48:15Z

@stephenxs could you pls help to review?

liat-grozovik · 2021-08-17T14:38:19Z

/azp run

azure-pipelines · 2021-08-17T14:38:33Z

Azure Pipelines successfully started running 1 pipeline(s).

tomer-israel · 2021-08-22T08:39:22Z

the errors on the checkers are not related to my change at all, the test is checking number of routes in the system:


test_PerfAddRemoveRoute failed (1 runs remaining out of 2).
	<class 'AssertionError'>
	Unexpected number of keys: expected=10007, received=10008 (('{"dest":"100.9.7.0/24","switch_id":"oid:0x21000000000000","vr":"oid:0x3000000000022"}', '{"dest":"100.28.67.0/24","switch_id":"oid:0x21000000000000","vr":"oid:0x3000000000022"}', 
...
'{"dest":"100.27.48.0/24","switch_id":"oid:0x21000000000000","vr":"oid:0x3000000000022"}')), table="ASIC_STATE:SAI_OBJECT_TYPE_ROUTE_ENTRY"
	[<TracebackEntry /home/vsts/work/1/s/tests/test_route.py:949>, <TracebackEntry /home/vsts/work/1/s/tests/dvslib/dvs_database.py:366>]

neethajohn · 2021-08-24T01:25:29Z

/azp run

azure-pipelines · 2021-08-24T01:25:39Z

Azure Pipelines successfully started running 1 pipeline(s).

neethajohn · 2021-08-25T18:36:19Z

/azp run

azure-pipelines · 2021-08-25T18:36:29Z

Azure Pipelines successfully started running 1 pipeline(s).

neethajohn · 2021-08-27T16:05:30Z

/azp run

azure-pipelines · 2021-08-27T16:05:41Z

Azure Pipelines successfully started running 1 pipeline(s).

liat-grozovik · 2021-09-09T07:57:38Z

/azp run

azure-pipelines · 2021-09-09T07:57:49Z

Azure Pipelines successfully started running 1 pipeline(s).

tomer-israel · 2021-09-22T10:35:16Z

the checkers were failed due to:
"[2021-09-12 13:11:15] [build-stderr] main.cpp:2:10: fatal error: sai.h: No such file or directory"

this error is not related to code change.

please rerun the checkers

tomer-israel · 2021-09-22T10:42:40Z

/azpw run

mssonicbld · 2021-09-22T10:42:41Z

/AzurePipelines run

azure-pipelines · 2021-09-22T10:42:52Z

Azure Pipelines successfully started running 1 pipeline(s).

liat-grozovik · 2021-09-29T17:47:17Z

/azp run

azure-pipelines · 2021-09-29T17:47:28Z

Azure Pipelines successfully started running 1 pipeline(s).

tomer-israel · 2021-09-30T11:49:55Z

/azpw run

azure-pipelines · 2021-10-07T14:03:34Z

Commenter does not have sufficient privileges for PR 1860 in repo Azure/sonic-swss

tomer-israel · 2021-10-07T14:13:47Z

/azpw run

mssonicbld · 2021-10-07T14:14:15Z

/AzurePipelines run

azure-pipelines · 2021-10-07T14:14:45Z

Azure Pipelines successfully started running 1 pipeline(s).

qiluo-msft · 2021-10-18T05:41:20Z

Just retriggered LGTM analysis: C/C++.

tomer-israel · 2021-10-19T11:31:17Z

/azpw run

mssonicbld · 2021-10-19T11:31:18Z

/AzurePipelines run

azure-pipelines · 2021-10-19T11:31:29Z

Azure Pipelines successfully started running 1 pipeline(s).

tomer-israel · 2021-10-20T11:25:44Z

/azpw run

mssonicbld · 2021-10-20T11:25:45Z

/AzurePipelines run

azure-pipelines · 2021-10-20T11:25:55Z

Azure Pipelines successfully started running 1 pipeline(s).

tomer-israel · 2021-10-28T14:17:06Z

failures not related to this change - rerun

/azpw run

tomer-israel · 2021-10-28T14:17:38Z

/azpw run

mssonicbld · 2021-10-28T14:17:39Z

/AzurePipelines run

azure-pipelines · 2021-10-28T14:17:49Z

Azure Pipelines successfully started running 1 pipeline(s).

tomer-israel · 2021-11-08T16:36:44Z

/azpw run

mssonicbld · 2021-11-08T16:36:46Z

/AzurePipelines run

azure-pipelines · 2021-11-08T16:36:56Z

Azure Pipelines successfully started running 1 pipeline(s).

Signed-off-by: tomeri <[email protected]>

liat-grozovik · 2021-11-11T12:33:06Z

@neethajohn and @stephenxs could you please help to review?

- What I did I added the removal of port buffer drop counter on the deinit port flow. it was added to the deInitPort function. - Why I did it the buffer drop counter was never removed when port was deleted. this flex counter was create on the initPort function but it was removed when the port was deleted - How I verified it removed and created a port and check the FLEX_COUNTER redis table FLEX_COUNTER_TABLE:PORT_BUFFER_DROP_STAT table

tomer-israel requested a review from prsunny as a code owner August 9, 2021 10:58

tomer-israel mentioned this pull request Aug 11, 2021

[portsyncd] when no ports on config db on init - continue and set PortConfigDone #1861

Merged

This was referenced Aug 11, 2021

SONiC Zero ports PR tracker sonic-net/sonic-buildimage#8431

Open

SONiC Zero ports PR tracker sonic-net/SONiC#835

Closed

prsunny requested a review from neethajohn August 11, 2021 16:54

stephenxs previously approved these changes Aug 18, 2021

View reviewed changes

neethajohn previously approved these changes Aug 24, 2021

View reviewed changes

[PORTSORCH] Remove buffer drop counter when port is removed

7019a19

Signed-off-by: tomeri <[email protected]>

tomer-israel dismissed stale reviews from neethajohn and stephenxs via 7019a19 November 10, 2021 19:58

tomer-israel force-pushed the port_buffer_drop_counter_del branch from 0ce6ba4 to 7019a19 Compare November 10, 2021 19:58

tomer-israel mentioned this pull request Nov 11, 2021

HLD document on add/remove ports dynamically feature sonic-net/SONiC#900

Merged

neethajohn approved these changes Nov 11, 2021

View reviewed changes

stephenxs approved these changes Nov 12, 2021

View reviewed changes

liat-grozovik changed the title ~~[orchagent] Remove buffer drop counter when port is deleted~~ Remove buffer drop counter when port is deleted Nov 15, 2021

liat-grozovik merged commit 4912a77 into sonic-net:master Nov 15, 2021

stephenxs mentioned this pull request Nov 17, 2021

[sonic-swss] Advance submodule sonic-net/sonic-buildimage#9288

Merged

5 tasks

Conversation

tomer-israel commented Aug 9, 2021

Uh oh!

tomer-israel commented Aug 9, 2021

Uh oh!

tomer-israel commented Aug 9, 2021

Uh oh!

azure-pipelines bot commented Aug 9, 2021

Uh oh!

tomer-israel commented Aug 11, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

liat-grozovik commented Aug 16, 2021

Uh oh!

liat-grozovik commented Aug 17, 2021

Uh oh!

azure-pipelines bot commented Aug 17, 2021

Uh oh!

tomer-israel commented Aug 22, 2021

Uh oh!

neethajohn commented Aug 24, 2021

Uh oh!

azure-pipelines bot commented Aug 24, 2021

Uh oh!

neethajohn commented Aug 25, 2021

Uh oh!

azure-pipelines bot commented Aug 25, 2021

Uh oh!

neethajohn commented Aug 27, 2021

Uh oh!

azure-pipelines bot commented Aug 27, 2021

Uh oh!

liat-grozovik commented Sep 9, 2021

Uh oh!

azure-pipelines bot commented Sep 9, 2021

Uh oh!

tomer-israel commented Sep 22, 2021

Uh oh!

tomer-israel commented Sep 22, 2021

Uh oh!

mssonicbld commented Sep 22, 2021

Uh oh!

azure-pipelines bot commented Sep 22, 2021

Uh oh!

liat-grozovik commented Sep 29, 2021

Uh oh!

azure-pipelines bot commented Sep 29, 2021

Uh oh!

tomer-israel commented Sep 30, 2021

Uh oh!

azure-pipelines bot commented Oct 7, 2021

Uh oh!

tomer-israel commented Oct 7, 2021

Uh oh!

mssonicbld commented Oct 7, 2021

Uh oh!

azure-pipelines bot commented Oct 7, 2021

Uh oh!

qiluo-msft commented Oct 18, 2021

Uh oh!

tomer-israel commented Oct 19, 2021

Uh oh!

mssonicbld commented Oct 19, 2021

Uh oh!

azure-pipelines bot commented Oct 19, 2021

Uh oh!

tomer-israel commented Oct 20, 2021

Uh oh!

mssonicbld commented Oct 20, 2021

Uh oh!

azure-pipelines bot commented Oct 20, 2021

Uh oh!

tomer-israel commented Oct 28, 2021

Uh oh!

tomer-israel commented Oct 28, 2021

Uh oh!

mssonicbld commented Oct 28, 2021

Uh oh!

azure-pipelines bot commented Oct 28, 2021

Uh oh!

tomer-israel commented Aug 11, 2021 •

edited

Loading