Skip to content

[fec] added logic that put port down before applying fec onfiguration#1399

Merged
liat-grozovik merged 1 commit intosonic-net:masterfrom
vadymhlushko-mlnx:fec_configuration
Aug 16, 2020
Merged

[fec] added logic that put port down before applying fec onfiguration#1399
liat-grozovik merged 1 commit intosonic-net:masterfrom
vadymhlushko-mlnx:fec_configuration

Conversation

@vadymhlushko-mlnx
Copy link
Contributor

Signed-off-by: Vadym Hlushko vadymh@mellanox.com

What I did

Added logic that put port down before applying FEC configuration, like in the case with speed change

Why I did it

Because if we don't put port down FEC changes will not apply

How I verified it

On the fanaout side:

  1. Put port down
  2. Change FEC
  3. Put port up

On the switch side:

  1. Change FEC
  2. Verify FEC state by using SDK script (in syncd docker)

Signed-off-by: Vadym Hlushko <vadymh@mellanox.com>
@volodymyrsamotiy
Copy link
Collaborator

retest this please

Copy link
Collaborator

@prsunny prsunny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@liat-grozovik liat-grozovik merged commit 90df31d into sonic-net:master Aug 16, 2020
abdosi pushed a commit that referenced this pull request Aug 19, 2020
EdenGri pushed a commit to EdenGri/sonic-swss that referenced this pull request Feb 28, 2022
As part of dual-tor features, kernel tunnel interface (tun0) is being created. The routes over this is intended for kernel forwarding and not expected to be installed in ASIC.

Ref PR - sonic-net#1615
Janetxxx pushed a commit to Janetxxx/sonic-swss that referenced this pull request Nov 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants